From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X506M-0002Wc-RE
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 18:12:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X506D-00024f-CQ
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 18:12:34 -0400
Received: from mail-vc0-x22d.google.com ([2607:f8b0:400c:c03::22d]:45986)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X506D-00024V-6v
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 18:12:25 -0400
Received: by mail-vc0-f173.google.com with SMTP id lf12so8819318vcb.32
	for <qemu-devel@nongnu.org>; Wed, 09 Jul 2014 15:12:24 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53BDBE44.3060504@redhat.com>
Date: Thu, 10 Jul 2014 00:12:20 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <alpine.DEB.2.02.1407092049550.29039@kaball.uk.xensource.com>	<53BDAFF3.1080007@redhat.com>
	<alpine.DEB.2.02.1407092247000.29039@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1407092247000.29039@kaball.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pass $($*.o-cflags) first to gcc/g++
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>, qemu-devel@nongnu.org

Il 09/07/2014 23:59, Stefano Stabellini ha scritto:
> On Wed, 9 Jul 2014, Paolo Bonzini wrote:
>> What package is it that has the conflicting utils.h file?  Any chance to get
>> it fixed in your distro?  Here I get:
>>
>> $ find /usr/include/ -name utils.h
>> /usr/include/libnl3/netlink/utils.h
>> /usr/include/libnl3/netlink/cli/utils.h
>> /usr/include/id3/utils.h
>> /usr/include/octave-3.6.4/octave/utils.h
>>
>> but none of them have the path in -I.
>
> It's Xen: when building QEMU as part of the Xen build process,
> tools/Makefile uses --extra-cflags to add the local Xen directories to
> the QEMU include path. However one of the Xen header files is named
> utils.h, conflicting with utils.h from disas/libvixl.
> It seems to be that --extra-cflags should come after the QEMU include
> paths.

I think the bug is in Xen then.  I have an oldish checkout and I see:

$ find . -name utils.h
./tools/console/daemon/utils.h
./tools/xenstore/utils.h

Could you move more headers to tools/include/ and avoid polluting 
QEMU_CFLAGS?

That said, for this particular case not using foo.o-cflags can be a 
stopgap solution too.

Paolo