From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5BYS-0007WY-Ls for qemu-devel@nongnu.org; Thu, 10 Jul 2014 06:26:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5BYK-0002IA-64 for qemu-devel@nongnu.org; Thu, 10 Jul 2014 06:26:20 -0400 Message-ID: <53BE6A41.2000209@suse.de> Date: Thu, 10 Jul 2014 12:26:09 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1404975681-4121-1-git-send-email-shreyas@linux.vnet.ibm.com> In-Reply-To: <1404975681-4121-1-git-send-email-shreyas@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Shreyas B. Prabhu" , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: Scott Wood , "Edgar E. Iglesias" , andreas.faerber@web.de, bharata@linux.vnet.ibm.com, Paolo Bonzini On 10.07.14 09:01, Shreyas B. Prabhu wrote: > Commit 0b183fc871:"memory: move mem_path handling to > memory_region_allocate_system_memory" split memory_region_init_ram and > memory_region_init_ram_from_file. Also it moved mem-path handling a step > up from memory_region_init_ram to memory_region_allocate_system_memory. > > Therefore for any board that uses memory_region_init_ram directly, > -mem-path is not supported. > > Fix this by replacing memory_region_init_ram with > memory_region_allocate_system_memory. > > Signed-off-by: Shreyas B. Prabhu It think it's reasonable to do this for all targets, except for spapr where Alexey is already working on a bigger patch. Could you please remove the spapr change so I can apply the rest to ppc-next already? Alex