From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5bTL-0002I3-Sv for qemu-devel@nongnu.org; Fri, 11 Jul 2014 10:06:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5bTH-00046g-2F for qemu-devel@nongnu.org; Fri, 11 Jul 2014 10:06:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5bTF-00046L-Jk for qemu-devel@nongnu.org; Fri, 11 Jul 2014 10:06:42 -0400 Message-ID: <53BFEF6C.9070606@redhat.com> Date: Fri, 11 Jul 2014 08:06:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405047682-26102-1-git-send-email-namei.unix@gmail.com> In-Reply-To: <1405047682-26102-1-git-send-email-namei.unix@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W7WLIHEgnltXIddA1bXOjmRqiVRVkcxe3" Subject: Re: [Qemu-devel] [PATCH] block/quorum: add simple read pattern support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan , qemu-devel@nongnu.org Cc: Kevin Wolf , Benoit Canet , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W7WLIHEgnltXIddA1bXOjmRqiVRVkcxe3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/10/2014 09:01 PM, Liu Yuan wrote: > This patch adds single read pattern to quorum driver and quorum vote is= default > pattern. >=20 > For now we do a quorum vote on all the reads, it is designed for unreli= able > underlying storage such as non-redundant NFS to make sure data integrit= y at the > cost of the read performance. >=20 > E.g, Enable single read pattern on 2 children, >=20 > -drive driver=3Dquorum,children.0.file.filename=3D0.qcow2,\ > children.1.file.filename=3D1.qcow2,read-pattern=3Dsingle,vote-threshold= =3D1 >=20 > [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device >=20 > Cc: Benoit Canet > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/quorum.c | 174 +++++++++++++++++++++++++++++++++++++++++--------= -------- > 1 file changed, 125 insertions(+), 49 deletions(-) That covers the command line, but what about the *.json changes to allow QMP to select this mode when hot-plugging? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --W7WLIHEgnltXIddA1bXOjmRqiVRVkcxe3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTv+9sAAoJEKeha0olJ0Nq2UsH/000IqajpzUjW6M0b4Ia7VQG To2upBcM1BHMYvNieYjQOSEqH1a3BN4kw+QibBhjmgCiCM7TzZuCLwvqE3xeo58C 6TnYcXRhsD6Rezl+wDp4Gu0BXcmITPqfttCDfBIohjraJguVYZD6KM6Dzy5LVaWC jaW/3+s+UcFrfJc/t6qnu2iJt5f+LQGYr9RYSmKqseJ8qD11tNsNypRIVVOF9uW6 X+EwIAQ7kCYWLeh5THA7ez+wKLj+pMoXq+dH1bNezMB8m3SMgLB/7+/jPsiNf/Ac TJbei4eXPHjzna1eyycY/pqCmgQHnsXAX3tMHVkzht8aty45NzA/8dLlDa/6GTY= =7dbw -----END PGP SIGNATURE----- --W7WLIHEgnltXIddA1bXOjmRqiVRVkcxe3--