Re: [Qemu-devel] [PATCH 37/46] Add assertion to check migration_dirty_pages doesn't go -ve; have seen it happen once but not sure why

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Long subject line. Also, spell out "negative" instead of abbreviating "-ve"

> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  arch_init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch_init.c b/arch_init.c
> index c006d21..58eccc1 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -439,6 +439,7 @@ ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr,
>  
>      if (next < size) {
>          clear_bit(next, migration_bitmap);
> +        assert(migration_dirty_pages > 0);
>          migration_dirty_pages--;
>      }
>      *bitoffset = next;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]