From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cd9-0006jf-CU for qemu-devel@nongnu.org; Fri, 11 Jul 2014 11:21:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5cd3-0005k3-CM for qemu-devel@nongnu.org; Fri, 11 Jul 2014 11:20:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cd3-0005jY-2l for qemu-devel@nongnu.org; Fri, 11 Jul 2014 11:20:53 -0400 Message-ID: <53C000D0.2090209@redhat.com> Date: Fri, 11 Jul 2014 09:20:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404495717-4239-1-git-send-email-dgilbert@redhat.com> <1404495717-4239-38-git-send-email-dgilbert@redhat.com> In-Reply-To: <1404495717-4239-38-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EkbxDsLRM9RenG8LmuR90pS65wkdC5nqG" Subject: Re: [Qemu-devel] [PATCH 37/46] Add assertion to check migration_dirty_pages doesn't go -ve; have seen it happen once but not sure why List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EkbxDsLRM9RenG8LmuR90pS65wkdC5nqG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" Long subject line. Also, spell out "negative" instead of abbreviating "-v= e" >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > arch_init.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/arch_init.c b/arch_init.c > index c006d21..58eccc1 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -439,6 +439,7 @@ ram_addr_t migration_bitmap_find_and_reset_dirty(Me= moryRegion *mr, > =20 > if (next < size) { > clear_bit(next, migration_bitmap); > + assert(migration_dirty_pages > 0); > migration_dirty_pages--; > } > *bitoffset =3D next; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EkbxDsLRM9RenG8LmuR90pS65wkdC5nqG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTwADQAAoJEKeha0olJ0NqfcIH/jsFKFl0UqZ/8GeJuth/IEVO LNjaOdX/Kw9fxgV+Ftw2eDeFdknbJM5hHS7EfsYZplJXS8dAR65MsMbJbhttqk/N jcd6CCcbGivYadfM1doaG6vSGiAMjhRB+QF/gsPimH9j/Fe4cJK0lxUzz7i3Nnyu xRz8vaAAPmBnVP4lEkkNjwN2EnfoOebIaavmztq3DsZSLloL3in5AlFqxqf1u7hl v5+1bxdTXbwnYGYAaYHxQ00lQa7Xmmj5fv6cvaUh+9gje+G1GY8y2E+BBjz3IIMl OWoamqGXRXCpmkdJegzWT41IGKxJISA3ZtbCG2unxPUUq+Pe6XRyL1fHT55jUEk= =NaBd -----END PGP SIGNATURE----- --EkbxDsLRM9RenG8LmuR90pS65wkdC5nqG--