From: Paolo Bonzini <pbonzini@redhat.com>
To: snabb-devel@googlegroups.com, qemu-devel@nongnu.org, mst@redhat.com
Cc: tech@virtualopensystems.com, n.nikolaev@virtualopensystems.com
Subject: Re: [Qemu-devel] [PATCH 0/3] vhost-user fixes
Date: Fri, 11 Jul 2014 22:57:24 +0200 [thread overview]
Message-ID: <53C04FB4.2040705@redhat.com> (raw)
In-Reply-To: <20140708140447.7314.87628.stgit@3820>
Il 08/07/2014 16:05, Nikolay Nikolaev ha scritto:
> The latest vhost-user changes changed the VHOST_SET_MEM_TABLE handling.
> Now the memory regions are mapped from dev->mem. The BIOS is registered
> at address 0xfffc0000 which is out of memory boundaries for guests with
> less than 4G RAM. Calling qemu_get_ram_fd with this address causes abort()
> in qemu_get_ram_block with "Bad ram offset".
>
> To prevent this situation we introduce a new function to check if the address
> maps to any RAMBlock - qemu_is_ram_block. This is used in VHOST_SET_MEM_TABLE
> handling to revent the aborting call to qemu_get_ram_fd.
>
> The related vhost-user qtest is also updated to reflect the changes in
> vhost-user message structures.
Patch 3 seems okay. Patches 1 and 2 are not but the actual fix is
similarly simple.
Paolo
prev parent reply other threads:[~2014-07-11 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 14:05 [Qemu-devel] [PATCH 0/3] vhost-user fixes Nikolay Nikolaev
2014-07-08 14:05 ` [Qemu-devel] [PATCH 1/3] Add qemu_is_ram_block Nikolay Nikolaev
2014-07-08 14:06 ` [Qemu-devel] [PATCH 2/3] vhost-user: Fix VHOST_SET_MEM_TABLE processing Nikolay Nikolaev
2014-07-11 20:56 ` Paolo Bonzini
2014-07-08 14:06 ` [Qemu-devel] [PATCH 3/3] qtest: Adapt vhost-user-test to latehs vhost-user changes Nikolay Nikolaev
2014-07-11 18:42 ` [Qemu-devel] [PATCH 0/3] vhost-user fixes Michael S. Tsirkin
2014-07-11 20:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C04FB4.2040705@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=n.nikolaev@virtualopensystems.com \
--cc=qemu-devel@nongnu.org \
--cc=snabb-devel@googlegroups.com \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).