From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5i2t-0005VS-AI for qemu-devel@nongnu.org; Fri, 11 Jul 2014 17:07:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5i2l-0003S4-4K for qemu-devel@nongnu.org; Fri, 11 Jul 2014 17:07:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5i2k-0003RD-Sc for qemu-devel@nongnu.org; Fri, 11 Jul 2014 17:07:47 -0400 Message-ID: <53C0521F.9030201@redhat.com> Date: Fri, 11 Jul 2014 23:07:43 +0200 From: Max Reitz MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 6/6] qcow2: Add falloc and full preallocation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Cc: Kevin Wolf , Yasunori Goto , Stefan Hajnoczi On 11.07.2014 08:10, Hu Tao wrote: > This adds preallocation=falloc and preallocation=full mode to qcow2 > image creation. > > preallocation=full allocates disk space by writing zeros to disk to > ensure disk space in any cases. > > preallocation=falloc likes preallocation=full, but allocates disk space > by posix_fallocate(). > > Signed-off-by: Hu Tao > --- > block/qcow2.c | 31 ++++++++++++++++++++++++-- > tests/qemu-iotests/082.out | 54 +++++++++++++++++++++++----------------------- > 2 files changed, 56 insertions(+), 29 deletions(-) Reviewed-by: Max Reitz