qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
	Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging
Date: Sat, 12 Jul 2014 02:39:21 +0200	[thread overview]
Message-ID: <53C083B9.2040506@suse.de> (raw)
In-Reply-To: <CAFEAcA-fek_z4UKsHyxmiWDxJV6rhCxonxO3g4DbfjrUXoRC5Q@mail.gmail.com>


On 11.07.14 20:22, Peter Maydell wrote:
> On 11 July 2014 19:15, Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
>> Peter Maydell <peter.maydell@linaro.org> wrote on 2014/07/11 19:14:25:
>>> On 11 July 2014 16:18, Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>> wrote:
>>>> ppc logs every type of Invalid instruction. This generates a lot
>>> Rather than just deleting this EXCP_DUMP, I would suggest
>>> changing the EXCP_DUMP macro so  it only does anything
>>> if the user has passed the "-d int" debug logging flag:
>> I don't think ppc wants that. They want unconditionally
>> debug on to get relevant bug reports. This one is getting in the
>> way of normal operations so I think it should be deleted.
> If the PPC maintainers want that behaviour then they need
> to defend it. No other architecture's linux-user code spews
> junk to stderr for exceptions, and PPC shouldn't either.
> The debug log switches are exactly for allowing us to
> say "please turn on debug logging" when bugs are reported,
> and those are what we should use.

I agree - and it's how we behave in system emulation mode already :).

What do the other platforms do on illegal instructions during user mode? 
Any way we can get consistency across the board?


Alex

  reply	other threads:[~2014-07-12  0:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 15:18 [Qemu-devel] [PATCH 0/4] make busybox udhcpc happy Joakim Tjernlund
2014-07-11 15:18 ` [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE) Joakim Tjernlund
2014-07-11 15:46   ` Peter Maydell
2014-07-11 16:07     ` Joakim Tjernlund
2014-07-11 17:02       ` Peter Maydell
2014-07-12  8:31         ` Joakim Tjernlund
2014-07-12  9:01           ` Peter Maydell
2014-07-12  9:48             ` Joakim Tjernlund
2014-07-12 10:42               ` Peter Maydell
2014-07-12 13:52                 ` Joakim Tjernlund
2014-07-12 15:13         ` Joakim Tjernlund
2014-07-12 15:47           ` Peter Maydell
2014-07-12 17:30             ` Joakim Tjernlund
2014-07-12 17:38               ` Peter Maydell
2014-07-12 18:11                 ` Joakim Tjernlund
2014-07-11 15:18 ` [Qemu-devel] [PATCH 2/4] linux-user: impl. sockaddr_ll Joakim Tjernlund
2014-07-11 16:00   ` Peter Maydell
2014-07-11 17:27     ` Joakim Tjernlund
2014-07-11 15:18 ` [Qemu-devel] [PATCH 3/4] alloca one extra byte sockets Joakim Tjernlund
2014-07-11 17:08   ` Peter Maydell
2014-07-15 13:29   ` Riku Voipio
2014-07-11 15:18 ` [Qemu-devel] [PATCH 4/4] ppc: remove excessive logging Joakim Tjernlund
2014-07-11 17:14   ` Peter Maydell
2014-07-11 18:15     ` Joakim Tjernlund
2014-07-11 18:22       ` Peter Maydell
2014-07-12  0:39         ` Alexander Graf [this message]
2014-07-12  8:24           ` [Qemu-devel] [Qemu-ppc] " Joakim Tjernlund
2014-07-16  9:17             ` Alex Bennée
2014-07-16 12:01               ` Peter Maydell
2014-07-12  8:58           ` Peter Maydell
2014-07-12  9:39             ` Alexander Graf
2014-07-12 10:40               ` Peter Maydell
2014-07-12 10:41                 ` Alexander Graf
2014-07-12 14:06                   ` Joakim Tjernlund
2014-07-16  7:55                     ` Riku Voipio
2014-07-16  8:32                       ` Joakim Tjernlund
2014-07-16  8:48                         ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C083B9.2040506@suse.de \
    --to=agraf@suse.de \
    --cc=joakim.tjernlund@transmode.se \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).