From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X5lLe-0000sY-Hn
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 20:39:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X5lLY-0004go-Uj
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 20:39:30 -0400
Message-ID: <53C083B9.2040506@suse.de>
Date: Sat, 12 Jul 2014 02:39:21 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1405091884-29955-1-git-send-email-Joakim.Tjernlund@transmode.se>	<1405091884-29955-5-git-send-email-Joakim.Tjernlund@transmode.se>	<CAFEAcA-qU3Q+936fVB3QEcK23k1cyeknKOHB61A0sH+-F=tXPA@mail.gmail.com>	<OFC4B69804.DD059A4F-ONC1257D12.0063EF91-C1257D12.00644BB8@transmode.se>
	<CAFEAcA-fek_z4UKsHyxmiWDxJV6rhCxonxO3g4DbfjrUXoRC5Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-fek_z4UKsHyxmiWDxJV6rhCxonxO3g4DbfjrUXoRC5Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive
	logging
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>


On 11.07.14 20:22, Peter Maydell wrote:
> On 11 July 2014 19:15, Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
>> Peter Maydell <peter.maydell@linaro.org> wrote on 2014/07/11 19:14:25:
>>> On 11 July 2014 16:18, Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>> wrote:
>>>> ppc logs every type of Invalid instruction. This generates a lot
>>> Rather than just deleting this EXCP_DUMP, I would suggest
>>> changing the EXCP_DUMP macro so  it only does anything
>>> if the user has passed the "-d int" debug logging flag:
>> I don't think ppc wants that. They want unconditionally
>> debug on to get relevant bug reports. This one is getting in the
>> way of normal operations so I think it should be deleted.
> If the PPC maintainers want that behaviour then they need
> to defend it. No other architecture's linux-user code spews
> junk to stderr for exceptions, and PPC shouldn't either.
> The debug log switches are exactly for allowing us to
> say "please turn on debug logging" when bugs are reported,
> and those are what we should use.

I agree - and it's how we behave in system emulation mode already :).

What do the other platforms do on illegal instructions during user mode? 
Any way we can get consistency across the board?


Alex