From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6l2K-0001BV-Tb for qemu-devel@nongnu.org; Mon, 14 Jul 2014 14:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6l2G-0005Jb-J3 for qemu-devel@nongnu.org; Mon, 14 Jul 2014 14:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6l2G-0005Iu-BS for qemu-devel@nongnu.org; Mon, 14 Jul 2014 14:31:36 -0400 Message-ID: <53C42204.6070909@redhat.com> Date: Mon, 14 Jul 2014 12:31:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140708141728.412a3f1c@redhat.com> <87fvi9i8tx.fsf@blackfin.pond.sub.org> <20140710103641.31b658c0@redhat.com> <87vbr4vtwp.fsf@blackfin.pond.sub.org> <53C004F2.1000602@redhat.com> <87tx6nsx3l.fsf@blackfin.pond.sub.org> <20140711145115.28849a0e@redhat.com> <53C05590.40409@redhat.com> <20140714141243.6390520f@redhat.com> In-Reply-To: <20140714141243.6390520f@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EAaFAjDhbAGoRst83kQuBw4DGUT57DIPK" Subject: Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: famz@redhat.com, Markus Armbruster , wenchaoqemu@gmail.com, qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EAaFAjDhbAGoRst83kQuBw4DGUT57DIPK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/14/2014 12:12 PM, Luiz Capitulino wrote: >>>> Agree. Let's ditch nested structs and see whether there are any mis= uses >>>> of c_var() left. >>> >>> This is an honest question: do we really want to drop nested struct s= upport, >>> wasn't it added by the block layer or am I just confused? >> >> We're talking about raw inline structs - there's only 3 impacted QAPI >> typesMP commands (if I counted correctly), and they have nothing to do= >> with block layer complex structs. The idea is that we want to outlaw >> 'foo':{...} implicit structs, and instead require 'foo':'type', where >> 'type' was earlier defined with the {...} guts. The QMP wire format >> would be unchanged; it is just a change to the QAPI template that the >> generators read. Removing inline structs would also simplify the >> generators. Then, with that gone, we are free to to repurpose >> 'foo':{...} for default values of optional arguments. Here's a link t= o >> some of the earlier conversation: >> >> https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html >> https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg04268.html >=20 > Right, this makes sense. Thanks for the URLs. >=20 > Is there anyone planning on doing this? I don't think I'll have cycles > anytime soon... I'd be willing to merge my fix if nobody steps up. I may take a stab at removing raw inline structs after 2.1 is released, if no one beats me to it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EAaFAjDhbAGoRst83kQuBw4DGUT57DIPK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTxCIEAAoJEKeha0olJ0Nq3MEIAKrR6QUtuRZRAn2plTgfrgaW M2eEPHTm6N8mwBTqf8bQhJywswcxODSGFzsB6ZV4zqL/TZ9l78Uiqh1iQHx+sves XzKJ4r6Ov3O0yCplCv/W81TqM5J7Lz5jjv3jw4+ZlV58WjVpO5rFRVl5EnI4o7u1 NVp0g/BY566mWbRgWnC8l6PmthWG+HTqy1pfR+RKSrdKrmgrd+LVlo146Hx0mp3H sKE5C5l0ecIbWocjpf6peiVa3zlFYI8RV4rzYjmW5sOUPJzp8KqjhQQw2usLL+sx ZiW7H+v6tqyEAhIvBX8dP+3FfIGcP+GsKlHUqEb4Y3aTJYtvFSsLvuczOU0HvcE= =toI4 -----END PGP SIGNATURE----- --EAaFAjDhbAGoRst83kQuBw4DGUT57DIPK--