From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X6nLx-0008Pw-8A
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 17:00:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X6nLp-00034N-P2
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 17:00:05 -0400
Message-ID: <53C444CB.3000609@suse.de>
Date: Mon, 14 Jul 2014 22:59:55 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1405004622-12304-1-git-send-email-aik@ozlabs.ru>	<53C3D77B.1000606@ozlabs.ru>
	<53C3DB90.1070000@redhat.com> <53C41262.4080207@suse.de>
In-Reply-To: <53C41262.4080207@suse.de>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] spapr: Enable huge pages
	again
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org


On 14.07.14 19:24, Alexander Graf wrote:
>
> On 14.07.14 15:30, Paolo Bonzini wrote:
>> Il 14/07/2014 15:13, Alexey Kardashevskiy ha scritto:
>>> On 07/11/2014 01:03 AM, Alexey Kardashevskiy wrote:
>>>> This does small RMA allocation rework and enables huge pages.
>>>>
>>>> Please comment, especially commit logs. Thanks!
>>>>
>>>> Changes:
>>>> v3:
>>>> * split to 2 patches, one mechanical
>>>> * tested on PPC970
>>>>
>>>> v2:
>>>> * moved RMA memory region out of KVM code
>>>
>>>
>>> This is 2.2 stuff, right? :)
>>
>> For me it would be okay for 2.1, but Alex may disagree.
>
> No, I agree. Missing huge page support is a regression over 2.0.
>
> Thanks, applied to for-2.1.

ppc-next of course.

I had to add this patch on top to make compilation work on non-PPC hosts:

diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h
index ac16a47..d9516e7 100644
--- a/target-ppc/kvm_ppc.h
+++ b/target-ppc/kvm_ppc.h
@@ -134,7 +134,7 @@ static inline int 
kvmppc_booke_watchdog_enable(PowerPCCPU *cpu)
  }

  #ifndef CONFIG_USER_ONLY
-static inline off_t kvmppc_alloc_rma(const char *name, MemoryRegion 
*sysmem)
+static inline off_t kvmppc_alloc_rma(void **rma)
  {
      return 0;
  }


Alex