From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1X6tNf-0002t1-Bl
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 23:26:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1X6tNZ-000507-7F
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 23:26:15 -0400
Received: from mail.uni-paderborn.de ([131.234.142.9]:18312)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1X6tNZ-0004zL-0o
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 23:26:09 -0400
Message-ID: <53C4AE2D.5030201@mail.uni-paderborn.de>
Date: Tue, 15 Jul 2014 05:29:33 +0100
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
MIME-Version: 1.0
References: <1405359671-25985-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1405359671-25985-7-git-send-email-kbastian@mail.uni-paderborn.de>
	<53C4461F.2070005@twiddle.net>
In-Reply-To: <53C4461F.2070005@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 06/15] target-tricore: Add instructions
 of SRC opcode format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org


>> +        tcg_gen_addi_tl(cpu_gpr_d[r1], cpu_gpr_d[r1], const4);
> Are you planning to come back to implement V and AV bits later?
Yes. I will do that in the next version of this patchset.
>
>> +    case OPC1_16_SRC_MOV_A:
>> +        /* load const4 again unsigned */
>> +        const4 = MASK_OP_SRC_CONST4(ctx->opcode);
>> +        tcg_gen_movi_tl(cpu_gpr_a[r1], const4);
> Err.. I don't think this is right.  I see "signed" on page 3-224.
Well this seemed to have changed over the instructionset version. If you 
look at the implemented CPU TC1796 it uses version 1.3 and you refer to 
version 1.6. However there should be a mechanism like arm_feature to 
handle this.
>
>> +    case OPC1_16_SRC_SHA:
>> +        /* FIXME: const too long */
>> +        gen_shaci(cpu_gpr_d[r1], cpu_gpr_d[r1], const4, 4);
>> +        break;
> Huh?  Why the fixme?
>
>
> r~