From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6yHd-0006I9-6t for qemu-devel@nongnu.org; Tue, 15 Jul 2014 04:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6yHW-0005wL-Rk for qemu-devel@nongnu.org; Tue, 15 Jul 2014 04:40:21 -0400 Sender: Paolo Bonzini Message-ID: <53C4E8DB.1040502@redhat.com> Date: Tue, 15 Jul 2014 10:39:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403720497-5318-1-git-send-email-pbonzini@redhat.com> <877g442kie.fsf@blackfin.pond.sub.org> <87fvi46jyc.fsf@blackfin.pond.sub.org> <1405413340.23139.7.camel@nilsson.home.kraxel.org> In-Reply-To: <1405413340.23139.7.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Markus Armbruster Cc: qemu-trivial , Peter Crosthwaite , "qemu-devel@nongnu.org Developers" Il 15/07/2014 10:35, Gerd Hoffmann ha scritto: > On Mo, 2014-07-14 at 17:25 +0200, Markus Armbruster wrote: >> Peter Crosthwaite writes: >> >>> On Thu, Jun 26, 2014 at 5:32 PM, Markus Armbruster wrote: >>>> Paolo Bonzini writes: >>>> >>>>> Otherwise, hot-unplug of pci-serial-2x trips the assertion >>>>> in memory_region_destroy: >>>>> >>>>> (qemu) device_del gg >>>>> (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021: >>>>> memory_region_destroy: Assertion `((&mr->subregions)->tqh_first == >>>>> ((void *)0))' failed. >>>>> Aborted (core dumped) >>>>> >>>>> Reported-by: Markus Armbruster >>>>> Signed-off-by: Paolo Bonzini >>>> >>>> Reviewed-by: Markus Armbruster >>>> >>> >>> Reviewed-by: Peter Crosthwaite >> >> Nominating for 2.1, just to be explicit. >> >> [...] > > Hmm, is trivial out of service? I remember thinking "Ok, trivial patch, > qemu-trivial is cc'ed, that'll pick it up, nothing to do for me." I think it's more likely that Michael went on vacation, from a quick look at his posting history. Paolo