From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X71kV-0005oE-De for qemu-devel@nongnu.org; Tue, 15 Jul 2014 08:22:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X71kQ-0005eQ-A2 for qemu-devel@nongnu.org; Tue, 15 Jul 2014 08:22:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X71kQ-0005cf-1E for qemu-devel@nongnu.org; Tue, 15 Jul 2014 08:22:18 -0400 Message-ID: <53C51CF6.6070900@redhat.com> Date: Tue, 15 Jul 2014 06:22:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405406098-30981-1-git-send-email-namei.unix@gmail.com> <1405406098-30981-3-git-send-email-namei.unix@gmail.com> In-Reply-To: <1405406098-30981-3-git-send-email-namei.unix@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wqQLllrQuJg0SHqMKjWE4715rkPfs0lmQ" Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wqQLllrQuJg0SHqMKjWE4715rkPfs0lmQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/15/2014 12:34 AM, Liu Yuan wrote: > Cc: Eric Blake > Signed-off-by: Liu Yuan > --- > qapi/block-core.json | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index e378653..22491bc 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1384,6 +1384,18 @@ > 'raw': 'BlockdevRef' } } > =20 > ## > +# @QuorumReadPattern > +# An enumeration of quorum read pattern. s/pattern/patterns/ > +# > +# @quorum: read all the children and do a quorum vote on reads > +# > +# @fifo: read a single child and try next child in FIFO order if read = fails. Inconsistent on whether you are ending a line with '.'. I'm not quite sure if this reads well; maybe: @fifo: read only from the first child that has not failed I also wonder if 'single' might be a better name than 'fifo', especially if we later add a 'round-robin' for read load balancing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wqQLllrQuJg0SHqMKjWE4715rkPfs0lmQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTxRz2AAoJEKeha0olJ0NqVk0H/1Jo9wALS3HJJ5U2D2QXI4QM iF6OfhCUG3CmYx2C61J//Ui6RI5rqHexpHU/z35K8HNEaZQU4lE6fPbgFfVSsJ2J aHRCKzZoF7xeKH7XP0KJye2EtJSRFQ6uHno4Ohlqt2pVU8ngLSqGKar7Ud92zwvQ 8bVrPKJNkugd7N7UhwJsaT/CPMemvTRR8bhmaDiRfbd65x2/pCfG545KiF0Xidis dpEw9bxAWN1JDCNTAfqO7BpWUXhYCRSUgtCVRfFn3LE5DDH+it5i8PVzXfWEgJbR NiPHeYzUYXM4lAaLNlen5bnmfBuT8VwbpiDxmz3e01BKBqNVNaRxqzgXkMtihLg= =q3It -----END PGP SIGNATURE----- --wqQLllrQuJg0SHqMKjWE4715rkPfs0lmQ--