From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 06/15] target-tricore: Add instructions of SRC opcode format
Date: Tue, 15 Jul 2014 14:19:22 +0100 [thread overview]
Message-ID: <53C52A5A.9090005@mail.uni-paderborn.de> (raw)
In-Reply-To: <53C4461F.2070005@twiddle.net>
>> + tcg_gen_addi_tl(cpu_gpr_d[r1], cpu_gpr_d[r1], const4);
> Are you planning to come back to implement V and AV bits later?
Would you recommend implementing this as a helper? It seems rather
complex. Especially with half-word and byte arithmetic. On the other
hand the instructions using this are common and would benefit from
open-coding it in TCG.
Thanks,
Bastian
next prev parent reply other threads:[~2014-07-15 12:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 17:40 [Qemu-devel] [PATCH v2 00/15] TriCore architecture guest implementation Bastian Koppelmann
2014-07-14 17:40 ` [Qemu-devel] [PATCH v2 01/15] target-tricore: Add target stubs and qom-cpu Bastian Koppelmann
2014-07-14 17:40 ` [Qemu-devel] [PATCH v2 02/15] target-tricore: Add board for systemmode Bastian Koppelmann
2014-07-14 17:40 ` [Qemu-devel] [PATCH v2 03/15] target-tricore: Add softmmu support Bastian Koppelmann
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 04/15] target-tricore: Add initialization for translation and activate target Bastian Koppelmann
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 05/15] target-tricore: Add masks and opcodes for decoding Bastian Koppelmann
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 06/15] target-tricore: Add instructions of SRC opcode format Bastian Koppelmann
2014-07-14 21:05 ` Richard Henderson
2014-07-15 4:29 ` Bastian Koppelmann
2014-07-15 13:19 ` Bastian Koppelmann [this message]
2014-07-15 15:42 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 07/15] target-tricore: Add instructions of SRR " Bastian Koppelmann
2014-07-15 15:00 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 08/15] target-tricore: Add instructions of SSR " Bastian Koppelmann
2014-07-15 15:17 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 09/15] target-tricore: Add instructions of SRRS and SLRO " Bastian Koppelmann
2014-07-15 15:23 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 10/15] target-tricore: Add instructions of SB " Bastian Koppelmann
2014-07-15 15:31 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 11/15] target-tricore: Add instructions of SBC and SBRN " Bastian Koppelmann
2014-07-15 15:33 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 12/15] target-tricore: Add instructions of SBR " Bastian Koppelmann
2014-07-15 15:50 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 13/15] target-tricore: Add instructions of SC " Bastian Koppelmann
2014-07-15 15:56 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 14/15] target-tricore: Add instructions of SLR, SSRO and SRO " Bastian Koppelmann
2014-07-15 16:00 ` Richard Henderson
2014-07-14 17:41 ` [Qemu-devel] [PATCH v2 15/15] target-tricore: Add instructions of SR " Bastian Koppelmann
2014-07-15 16:50 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C52A5A.9090005@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).