From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, stefanha@redhat.com
Cc: mohamad.gebai@gmail.com, qemu-devel@nongnu.org,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity
Date: Tue, 15 Jul 2014 15:19:34 +0200 [thread overview]
Message-ID: <53C52A66.5000906@redhat.com> (raw)
In-Reply-To: <1405424541-21803-4-git-send-email-alex.bennee@linaro.org>
Il 15/07/2014 13:42, Alex Bennée ha scritto:
> + trace_inc_counter(&cpu->tb_jmp_cache_stats.misses);
> tb = tb_find_slow(env, pc, cs_base, flags);
> + } else {
> + trace_inc_counter(&cpu->tb_jmp_cache_stats.hits);
> }
I think this is premature optimization...
Paolo
next prev parent reply other threads:[~2014-07-15 13:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 11:42 [Qemu-devel] [PATCH v2 0/3] some TCG related trace patches Alex Bennée
2014-07-15 11:42 ` [Qemu-devel] [PATCH v2 1/3] trace: teach lttng backend to use format strings Alex Bennée
2014-08-01 9:05 ` Alex Bennée
2014-08-01 12:54 ` Stefan Hajnoczi
2014-07-15 11:42 ` [Qemu-devel] [PATCH v2 2/3] trace: add some tcg tracing support Alex Bennée
2014-07-15 11:42 ` [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity Alex Bennée
2014-07-15 12:15 ` Andreas Färber
2014-07-15 13:12 ` Alex Bennée
2014-07-15 12:23 ` Peter Maydell
2014-07-15 13:07 ` Peter Maydell
2014-07-15 13:10 ` Alex Bennée
2014-07-15 13:19 ` Paolo Bonzini [this message]
2014-07-15 14:16 ` Alex Bennée
2014-07-15 20:11 ` Paolo Bonzini
2014-07-15 20:29 ` Peter Maydell
2014-07-15 20:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C52A66.5000906@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=mohamad.gebai@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).