From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X72eD-00055P-N8 for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X72e4-0004zd-Mv for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:19:57 -0400 Received: from mail-qg0-x233.google.com ([2607:f8b0:400d:c04::233]:62566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X72e4-0004zW-JL for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:19:48 -0400 Received: by mail-qg0-f51.google.com with SMTP id a108so4714856qge.10 for ; Tue, 15 Jul 2014 06:19:48 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53C52A66.5000906@redhat.com> Date: Tue, 15 Jul 2014 15:19:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1405424541-21803-1-git-send-email-alex.bennee@linaro.org> <1405424541-21803-4-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1405424541-21803-4-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , stefanha@redhat.com Cc: mohamad.gebai@gmail.com, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Il 15/07/2014 13:42, Alex Bennée ha scritto: > + trace_inc_counter(&cpu->tb_jmp_cache_stats.misses); > tb = tb_find_slow(env, pc, cs_base, flags); > + } else { > + trace_inc_counter(&cpu->tb_jmp_cache_stats.hits); > } I think this is premature optimization... Paolo