From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X74zy-0005CU-6X for qemu-devel@nongnu.org; Tue, 15 Jul 2014 11:50:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X74zs-0005qb-Sq for qemu-devel@nongnu.org; Tue, 15 Jul 2014 11:50:33 -0400 Received: from mail-ig0-x232.google.com ([2607:f8b0:4001:c05::232]:48756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X74zs-0005qI-JZ for qemu-devel@nongnu.org; Tue, 15 Jul 2014 11:50:28 -0400 Received: by mail-ig0-f178.google.com with SMTP id uq10so3060151igb.11 for ; Tue, 15 Jul 2014 08:50:28 -0700 (PDT) Sender: Richard Henderson Message-ID: <53C54DC0.9000408@twiddle.net> Date: Tue, 15 Jul 2014 08:50:24 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1405359671-25985-1-git-send-email-kbastian@mail.uni-paderborn.de> <1405359671-25985-13-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1405359671-25985-13-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 12/15] target-tricore: Add instructions of SBR opcode format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 07/14/2014 10:41 AM, Bastian Koppelmann wrote: > Add instructions of SBR opcode format. > Add gen_loop micro-op generator function. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - Change gen_loop() to subtract first and then compare to -1. > - Change gen_loop() using next_pc insted of insn_bytes. > - Change SBR_LOOP instructions to use offset * 2 -32. > > target-tricore/translate.c | 66 +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 65 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~