From: "Marcin Gibuła" <m.gibula@beyond.pl>
To: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation
Date: Tue, 15 Jul 2014 22:03:00 +0200 [thread overview]
Message-ID: <53C588F4.4040307@beyond.pl> (raw)
In-Reply-To: <53C584D3.8090109@redhat.com>
>> @@ -65,6 +66,7 @@ static uint64_t kvmclock_current_nsec(KVMClockState *s)
>>
>> cpu_physical_memory_read(kvmclock_struct_pa, &time, sizeof(time));
>>
>> + assert(time.tsc_timestamp <= migration_tsc);
>> delta = migration_tsc - time.tsc_timestamp;
>> if (time.tsc_shift < 0) {
>> delta >>= -time.tsc_shift;
>> @@ -123,6 +125,8 @@ static void kvmclock_vm_state_change(void *opaque,
>> int running,
>> if (s->clock_valid) {
>> return;
>> }
>> +
>> + cpu_synchronize_all_states();
>> ret = kvm_vm_ioctl(kvm_state, KVM_GET_CLOCK, &data);
>> if (ret < 0) {
>> fprintf(stderr, "KVM_GET_CLOCK failed: %s\n",
>> strerror(ret));
>>
>>
>
> This causes a hang during migration, so I'll revert the patch from 2.1.
For me this patch series fixed all hangs I had with migration (at least
with qemu 2.0).
--
mg
next prev parent reply other threads:[~2014-07-15 20:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:15 [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward Alexander Graf
2014-05-18 13:20 ` Marcelo Tosatti
2014-05-19 11:31 ` Paolo Bonzini
2014-05-21 10:03 ` Alexander Graf
2014-06-02 20:31 ` Marcin Gibuła
2014-06-03 5:16 ` Marcelo Tosatti
2014-06-03 9:11 ` Marcin Gibuła
2014-06-03 11:13 ` Paolo Bonzini
2014-06-03 16:34 ` [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation Marcelo Tosatti
2014-07-15 19:45 ` Paolo Bonzini
2014-07-15 20:03 ` Marcin Gibuła [this message]
2014-07-15 20:15 ` Paolo Bonzini
2014-07-15 20:31 ` Marcelo Tosatti
2014-07-15 20:34 ` Marcelo Tosatti
2014-07-15 20:43 ` Paolo Bonzini
2014-07-15 21:05 ` Andrey Korolyov
2014-07-15 21:08 ` Paolo Bonzini
2014-07-15 20:43 ` Paolo Bonzini
2014-07-15 19:44 ` [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C588F4.4040307@beyond.pl \
--to=m.gibula@beyond.pl \
--cc=agraf@suse.de \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).