From: "Marcin Gibuła" <m.gibula@beyond.pl>
To: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock
Date: Tue, 15 Jul 2014 22:15:25 +0200 [thread overview]
Message-ID: <53C58BDD.1040306@beyond.pl> (raw)
In-Reply-To: <53C54602.6050003@redhat.com>
W dniu 2014-07-15 17:17, Paolo Bonzini pisze:
> Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto:
>> v2:
>> * Leave BH scheduled so that the code can be simplified [Paolo]
>>
>> These patches convert thread-pool.c from EventNotifier to QEMUBH.
>> They then
>> solve the deadlock when nested aio_poll() calls are made.
>>
>> Please speak out whether you want this in QEMU 2.1 or not. I'm not
>> aware of
>> the nested aio_poll() deadlock ever having been reported, so maybe we
>> can defer
>> to QEMU 2.2.
>
> It was reported as a hang in block_commit. Marcin, can you please test
> these patches?
I try to test it tomorrow. The same hang was also in linux-aio however
(I was able to reproduce it).
--
mg
next prev parent reply other threads:[~2014-07-15 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 14:44 [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock Stefan Hajnoczi
2014-07-15 14:44 ` [Qemu-devel] [PATCH v2 1/2] thread-pool: avoid per-thread-pool EventNotifier Stefan Hajnoczi
2014-07-15 14:44 ` [Qemu-devel] [PATCH v2 2/2] thread-pool: avoid deadlock in nested aio_poll() calls Stefan Hajnoczi
2014-07-15 15:18 ` Paolo Bonzini
2014-07-15 15:17 ` [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock Paolo Bonzini
2014-07-15 20:15 ` Marcin Gibuła [this message]
2014-08-05 15:08 ` Marcin Gibuła
2014-08-01 13:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C58BDD.1040306@beyond.pl \
--to=m.gibula@beyond.pl \
--cc=borntraeger@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).