From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Linux
Date: Tue, 15 Jul 2014 22:15:45 +0200 [thread overview]
Message-ID: <53C58BF1.4080401@redhat.com> (raw)
In-Reply-To: <1405445704-32450-1-git-send-email-peter.maydell@linaro.org>
Il 15/07/2014 19:35, Peter Maydell ha scritto:
> vhost-user-test uses the linux/vhost.h header, so it must only be
> enabled if CONFIG_LINUX is defined. (Previously it was enabled
> for CONFIG_POSIX, which broke 'make check' on MacOSX.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I'm going to commit this for the 2.1-rc2 tag I'm about to do,
> since it's such a trivial change...
Yes, the right thing to do is probably to distribute linux/vhost.h but
it's 2.2 material.
Paolo
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 1fcd633..fa25c70 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -158,7 +158,7 @@ gcov-files-i386-y += hw/usb/hcd-ehci.c
> gcov-files-i386-y += hw/usb/hcd-uhci.c
> gcov-files-i386-y += hw/usb/dev-hid.c
> gcov-files-i386-y += hw/usb/dev-storage.c
> -check-qtest-i386-$(CONFIG_POSIX) += tests/vhost-user-test$(EXESUF)
> +check-qtest-i386-$(CONFIG_LINUX) += tests/vhost-user-test$(EXESUF)
> check-qtest-x86_64-y = $(check-qtest-i386-y)
> gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
> gcov-files-x86_64-y = $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
>
next prev parent reply other threads:[~2014-07-15 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 17:35 [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Linux Peter Maydell
2014-07-15 20:15 ` Paolo Bonzini [this message]
2014-07-15 20:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C58BF1.4080401@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=n.nikolaev@virtualopensystems.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).