From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X798l-0006DY-9h
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 16:16:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X798f-0005ZY-Sc
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 16:15:55 -0400
Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:46661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X798f-0005Yx-D6
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 16:15:49 -0400
Received: by mail-qc0-f169.google.com with SMTP id m20so3607150qcx.28
	for <qemu-devel@nongnu.org>; Tue, 15 Jul 2014 13:15:49 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53C58BF1.4080401@redhat.com>
Date: Tue, 15 Jul 2014 22:15:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1405445704-32450-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1405445704-32450-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test
	on Linux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>, "Michael S. Tsirkin" <mst@redhat.com>

Il 15/07/2014 19:35, Peter Maydell ha scritto:
> vhost-user-test uses the linux/vhost.h header, so it must only be
> enabled if CONFIG_LINUX is defined. (Previously it was enabled
> for CONFIG_POSIX, which broke 'make check' on MacOSX.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I'm going to commit this for the 2.1-rc2 tag I'm about to do,
> since it's such a trivial change...

Yes, the right thing to do is probably to distribute linux/vhost.h but 
it's 2.2 material.

Paolo

>  tests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 1fcd633..fa25c70 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -158,7 +158,7 @@ gcov-files-i386-y += hw/usb/hcd-ehci.c
>  gcov-files-i386-y += hw/usb/hcd-uhci.c
>  gcov-files-i386-y += hw/usb/dev-hid.c
>  gcov-files-i386-y += hw/usb/dev-storage.c
> -check-qtest-i386-$(CONFIG_POSIX) += tests/vhost-user-test$(EXESUF)
> +check-qtest-i386-$(CONFIG_LINUX) += tests/vhost-user-test$(EXESUF)
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>  gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
>  gcov-files-x86_64-y = $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
>