From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X7P8h-0004ba-Vn
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 09:21:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X7P8a-0006Gm-GD
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 09:20:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19697)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X7P8a-0006Gb-0F
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 09:20:48 -0400
Message-ID: <53C67C00.5000203@redhat.com>
Date: Wed, 16 Jul 2014 15:20:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1405513086-31246-1-git-send-email-sebastian.tanase@openwide.fr>
In-Reply-To: <1405513086-31246-1-git-send-email-sebastian.tanase@openwide.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay
 algorithm between guest and host clocks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Tanase <sebastian.tanase@openwide.fr>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@amazon.com, wenchaoqemu@gmail.com, quintela@redhat.com, mst@redhat.com, stefanha@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, michael@walle.cc, camille.begue@openwide.fr, alex@alex.org.uk, crobinso@redhat.com, afaerber@suse.de, rth@twiddle.net

Il 16/07/2014 14:18, Sebastian Tanase ha scritto:
> v3 -> v4
>
> * Add better error handling for 'strtol' in patch 2
> * Add 'Sleep' instead of 'nanosleep' for Windows hosts in patch 4
> * Remove function pointers from patches 4 and 5

Hi Sebastian, I think we're getting really close.

I asked a question about clocks_offset; I think it's not necessary to 
compute it in cpu-exec.c because the same information is available 
elsewhere.  It is also probably not necessary to make it public.  Can 
you please check this?  Once this is sorted out, the patch should be 
ready for inclusion in 2.2.

Thanks for your effort!

Paolo