From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7RtS-0006Hj-Fn for qemu-devel@nongnu.org; Wed, 16 Jul 2014 12:17:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7RtM-00050q-QP for qemu-devel@nongnu.org; Wed, 16 Jul 2014 12:17:22 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:51691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7RtM-00050X-J5 for qemu-devel@nongnu.org; Wed, 16 Jul 2014 12:17:16 -0400 Received: by mail-wi0-f172.google.com with SMTP id n3so6482491wiv.17 for ; Wed, 16 Jul 2014 09:17:15 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53C6A587.9020009@redhat.com> Date: Wed, 16 Jul 2014 18:17:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <3b8cd70724017ab9604f1c34644df75549e61846.1405525932.git.luto@amacapital.net> In-Reply-To: <3b8cd70724017ab9604f1c34644df75549e61846.1405525932.git.luto@amacapital.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu] i386, linux-headers: Add support for kvm_get_rng_seed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andy Lutomirski , kvm@vger.kernel.org, "H. Peter Anvin" , Theodore Ts'o , linux-kernel@vger.kernel.org, Kees Cook , x86@kernel.org, qemu-devel@nongnu.org Cc: Daniel Borkmann , Raghavendra K T , Srivatsa Vaddagiri Il 16/07/2014 17:52, Andy Lutomirski ha scritto: > This updates x86's kvm_para.h for the feature bit definition and > target-i386/cpu.c for the feature name and default. > > Signed-off-by: Andy Lutomirski Thanks, looks good---assuming the kernel side will make it into 3.17, I'll sync the headers once 3.17 is released and then apply the patch. As mentioned in kvm@ someone will have to add the pc-2.2 machine type too. Paolo > --- > linux-headers/asm-x86/kvm_para.h | 2 ++ > target-i386/cpu.c | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/linux-headers/asm-x86/kvm_para.h b/linux-headers/asm-x86/kvm_para.h > index e41c5c1..a9b27ce 100644 > --- a/linux-headers/asm-x86/kvm_para.h > +++ b/linux-headers/asm-x86/kvm_para.h > @@ -24,6 +24,7 @@ > #define KVM_FEATURE_STEAL_TIME 5 > #define KVM_FEATURE_PV_EOI 6 > #define KVM_FEATURE_PV_UNHALT 7 > +#define KVM_FEATURE_GET_RNG_SEED 8 > > /* The last 8 bits are used to indicate how to interpret the flags field > * in pvclock structure. If no bits are set, all flags are ignored. > @@ -40,6 +41,7 @@ > #define MSR_KVM_ASYNC_PF_EN 0x4b564d02 > #define MSR_KVM_STEAL_TIME 0x4b564d03 > #define MSR_KVM_PV_EOI_EN 0x4b564d04 > +#define MSR_KVM_GET_RNG_SEED 0x4b564d05 > > struct kvm_steal_time { > __u64 steal; > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 8fd1497..4ea7e6c 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -236,7 +236,7 @@ static const char *ext4_feature_name[] = { > static const char *kvm_feature_name[] = { > "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", > "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", "kvm_pv_unhalt", > - NULL, NULL, NULL, NULL, > + "kvm_get_rng_seed", NULL, NULL, NULL, > NULL, NULL, NULL, NULL, > NULL, NULL, NULL, NULL, > NULL, NULL, NULL, NULL, > @@ -368,7 +368,8 @@ static uint32_t kvm_default_features[FEATURE_WORDS] = { > (1 << KVM_FEATURE_ASYNC_PF) | > (1 << KVM_FEATURE_STEAL_TIME) | > (1 << KVM_FEATURE_PV_EOI) | > - (1 << KVM_FEATURE_CLOCKSOURCE_STABLE_BIT), > + (1 << KVM_FEATURE_CLOCKSOURCE_STABLE_BIT) | > + (1 << KVM_FEATURE_GET_RNG_SEED), > [FEAT_1_ECX] = CPUID_EXT_X2APIC, > }; > >