From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7SOo-0002S0-My for qemu-devel@nongnu.org; Wed, 16 Jul 2014 12:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7SOe-0007oJ-Q0 for qemu-devel@nongnu.org; Wed, 16 Jul 2014 12:49:46 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:48696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7SOe-0007oD-JK for qemu-devel@nongnu.org; Wed, 16 Jul 2014 12:49:36 -0400 Received: by mail-we0-f176.google.com with SMTP id q58so1232750wes.7 for ; Wed, 16 Jul 2014 09:49:35 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53C6AD18.8030102@redhat.com> Date: Wed, 16 Jul 2014 18:49:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140716002632.23073.40357@loki> <53C6A816.9090306@weilnetz.de> In-Reply-To: <53C6A816.9090306@weilnetz.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Lieven Il 16/07/2014 18:28, Stefan Weil ha scritto: > Debian testing includes a brand new libiscsi, but it > does not include libiscsi.pc, so pkg-config won't know that it is > available and configure will disable libiscsi. That's a packaging bug. > I have a patch which > fixes this, so QEMU for Debian testing could include libiscsi again. > > Is a feature regression like this one acceptable? Do we need additional > testing (maybe run the build bots with --enable-xxx, so builds fail when > xxx no longer works)? As mentioned in the e49ab19fcaa617ad6cdfe1ac401327326b6a2552 commit message, this was intentional. I was reluctant to do it, but ultimately Peter Lieven convinced me that it isn't just about using fancy new APIs; libiscsi was too buggy to be useful until release 1.8.0 (even 1.9.0 requires a patch to avoid segfaults, and many more if you want to run it on ARM). Paolo