From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7TdX-0000We-6w for qemu-devel@nongnu.org; Wed, 16 Jul 2014 14:09:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7TdR-0007Gk-EZ for qemu-devel@nongnu.org; Wed, 16 Jul 2014 14:09:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7TdR-0007Gg-5P for qemu-devel@nongnu.org; Wed, 16 Jul 2014 14:08:57 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6GI8ulG011324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jul 2014 14:08:56 -0400 Message-ID: <53C6BFB7.70804@redhat.com> Date: Wed, 16 Jul 2014 12:08:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405525697-9378-1-git-send-email-kwolf@redhat.com> <1405525697-9378-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1405525697-9378-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OQt6xMPeajMSS4pGIgqFHU6KpbiAIQc0i" Subject: Re: [Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working alignment is found List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OQt6xMPeajMSS4pGIgqFHU6KpbiAIQc0i Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/16/2014 09:48 AM, Kevin Wolf wrote: > If qemu couldn't find out what O_DIRECT alignment to use with a given > file, it would run into assert(bdrv_opt_mem_align(bs) !=3D 0); in block= =2Ec > and confuse users. This adds a more descriptive error message for such > cases. >=20 > Signed-off-by: Kevin Wolf > --- > block/raw-posix.c | 35 +++++++++++++++++++++++++++-------- > 1 file changed, 27 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OQt6xMPeajMSS4pGIgqFHU6KpbiAIQc0i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTxr+3AAoJEKeha0olJ0NqNpcH/AhKJLzjVG2jKY80UCVKC/MH KNEgOupMlJd9otSlRK8bchUgpzKEoSX7O14m3mGdorKv1OCoIRkcjZ0A3Y3EnhbD ucxgxymYVyeTKz7PzM1gJcVakiadj3vAOvZDvuVcoO3uqtpn7bYe3SVhamPPw2jF LkqORu4rxFJEbm24wdK/dYJFTLEme0AdQXxBK/Qbzyb2vA9FBxRwGoNWltq4Ir3A qQvf7D3eLPljQwP9MPgrnR4vaFbCD9C8vuPC3gDRQC7TF5fdy2GjAKPc0AnHwVZM Ks3JyEm6LMwg43T48VpBhlvqJLwVLK8NleV2gKPRH3JqLfUZ1o8tmfjtPbiipuA= =zl3a -----END PGP SIGNATURE----- --OQt6xMPeajMSS4pGIgqFHU6KpbiAIQc0i--