From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7lXo-0007Mn-Qo for qemu-devel@nongnu.org; Thu, 17 Jul 2014 09:16:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7lXf-0005qv-Le for qemu-devel@nongnu.org; Thu, 17 Jul 2014 09:16:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7lXf-0005qY-CR for qemu-devel@nongnu.org; Thu, 17 Jul 2014 09:16:11 -0400 Message-ID: <53C7CC93.1050100@redhat.com> Date: Thu, 17 Jul 2014 07:16:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405590113-17052-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1405590113-17052-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mB79MfMiFxgAwieaP9LeVx1mCromciGJK" Subject: Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incompatible features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: maria.k@catit.be, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mB79MfMiFxgAwieaP9LeVx1mCromciGJK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 03:41 AM, Kevin Wolf wrote: > qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation > would prevent feature table entries for bits 32-63 from being used, and= > it could assign errp multiple times if there was more than one unknown > feature, resulting in an error_set() assertion failure. >=20 > Fix the truncation, make sure to set the error exactly once and add a > qemu-iotests case for it. >=20 > This fixes https://bugs.launchpad.net/qemu/+bug/1342704/ >=20 > Reported-by: Maria Kustova > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 21 +++++++++++++----- > tests/qemu-iotests/036 | 52 +++++++++++++++++++++++++++++++++++++= +++++++- > tests/qemu-iotests/036.out | 35 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/qcow2.py | 15 ++++++++----- > 4 files changed, 112 insertions(+), 11 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mB79MfMiFxgAwieaP9LeVx1mCromciGJK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTx8yTAAoJEKeha0olJ0NqQScH/1fBZdcUlnVWsDCqYUVKgD+T juNtZdJ9npAt2346EMWeElKsGY159pznpHqGJOYBDX00l9S5A3piu9deum0z7V8a eLRXdZP8yvQvgUxmk5UN49BI9vHjO12/zOYUfC4ETyfsSyCxpmHbJ2Y7P/fdesvH OwyM35TOyNQUTC7l8AE/ADntT1CoUBeCCrwsrYkotqCYuZc0Li6OhGTt996EBnjS EIHoRbmj8/ioo0dmk1AugxcCnsgUA81mXYkcV0XA0m1xGG9u0Je4DSkD49ZGqdYB mTsVIsLHv4G31aHiHjzyRQfVfythM/LV9yAyPxHOk1wTHyFyW/wGWN9qf7dLmoU= =4Gsm -----END PGP SIGNATURE----- --mB79MfMiFxgAwieaP9LeVx1mCromciGJK--