From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X875f-0002FO-S9 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:16:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X875a-0004nc-3D for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:16:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X875Z-0004nW-RC for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:16:38 -0400 Message-ID: <53C91023.5000109@redhat.com> Date: Fri, 18 Jul 2014 06:16:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <1405596081-29701-3-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-3-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O1NqQSqrmkAJ0aUnXUM1CgFAT79a7wedV" Subject: Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O1NqQSqrmkAJ0aUnXUM1CgFAT79a7wedV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Changed those files that were directly using the RUN_STATE_RUNNING flag= =2E Now, > they have been replaced by the runstate_is_running() function. >=20 > Signed-off-by: Sanidhya Kashyap > --- > hw/usb/hcd-ehci.c | 2 +- > hw/usb/redirect.c | 6 +++--- > qapi-schema.json | 7 ++++++- > vl.c | 29 ++++++++++++++++++++++++++++- > 4 files changed, 38 insertions(+), 6 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -145,12 +145,17 @@ > # @watchdog: the watchdog action is configured to pause and has been t= riggered > # > # @guest-panicked: guest has been panicked as a result of guest OS pan= ic > +# > +# @migrate: migration process is being executed > +# > +# @dump-bitmap: dump the writable working set of the guest Please document these new flags as (since 2.2). How does 'migrate' differ from 'inmigrate' and 'finish-migrate'? Why do you need to introduce 'dump-bitmap' again? How will this interact with older libvirt that doesn't know about the state? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --O1NqQSqrmkAJ0aUnXUM1CgFAT79a7wedV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyRAjAAoJEKeha0olJ0NqhUUH/321sg6dOsyt91fXPv6HkKxc wDapQfPZBTZ923EgHCL2jMNZ6cfs3e5MUOxxnXrMPTVoXdSag4IVijnoSJh8TsfH TpOGwy/NoF9e0fY2cZ5MAy0fC5mPrYF+JpyZ+i/NbgLWPiQQa1INnj9SBGvJDLjm nAXR49iH6LpKVBADjdIrvGVWMFzHIAWYHfDeeSz/bMhyglQitQPTVwffCcjwFs8R BuijdSFg+/FAZ2PyVJSIfV2M3SHsOzIv9T+4igRDnN93+eZt4B4lDFLvoKjZOyoQ t1020LyKjB2zry0ScHKCyl1KTKNp+j1FD/RHzsIA62I5Kyb4/45HoJSTl+4ZM3M= =ql/A -----END PGP SIGNATURE----- --O1NqQSqrmkAJ0aUnXUM1CgFAT79a7wedV--