From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X879L-000547-N7 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X879F-0006RE-LJ for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:20:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X879F-0006R1-Dk for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:20:25 -0400 Message-ID: <53C91105.2070008@redhat.com> Date: Fri, 18 Jul 2014 06:20:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <1405596081-29701-4-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-4-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MjMSuRCj7efoLfj47VhtArK6dpfuwEuTE" Subject: Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MjMSuRCj7efoLfj47VhtArK6dpfuwEuTE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Reformatted the code and added the functionality of dumping the blocks'= info > which can be read by the user when required. I have also made the block= name > length global. > Some minor modification to the structure which is now storing all the > information. >=20 > Signed-off-by: Sanidhya Kashyap > --- > include/exec/cpu-all.h | 4 +- > migration.c | 7 ++ > qapi-schema.json | 18 +++ > qmp-commands.hx | 30 +++++ > savevm.c | 325 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > 5 files changed, 383 insertions(+), 1 deletion(-) >=20 > +++ b/qapi-schema.json > @@ -3485,3 +3485,21 @@ > # Since: 2.1 > ## > { 'command': 'rtc-reset-reinjection' } > + > +## > +# @log-dirty-bitmap > +# > +# dumps the dirty bitmap to a file by logging the > +# memory for a specified number of times with a > +# a defined time differnce s/differnce/difference/ > +# > +# @filename: name of the file in which the bitmap will be saved. > +# @epochs: number of times the memory will be logged (optional). > +# @frequency: time difference in milliseconds between each epoch (opti= onal). and their default values? When I see epoch in relation to programming, my first thought is 1970-01-01 - not something that can be plural. Would that variable be better named 'iterations'? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MjMSuRCj7efoLfj47VhtArK6dpfuwEuTE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyREFAAoJEKeha0olJ0NqpI4H/jV1w0gs9nmzoLRSmct5DQZQ SlXV8sRsaHNVxstjsFDzWyk4bEn0k8HrkSN5Hn1u3emU2GCspH1aQaMDwqY+YgzQ 49wNsCVKNm+y2YWXw4BfBEsWNsZXEwu8i7LDWT2FRqwB7lBDoyLd9tOuP5PVC5sE KgRtOZNGooD0yg8dOXwIAK8B8YMyjeaGtNxPg9C+WuDYouepdx5Noy0EYu2Fynh+ yIUZUQr5m1vwqZzIDJ9QKRTuMKD/8aUHnGWeZ9EZkvO2aF91syf/r3HvPEveJQmD puhLLRy3kL8fVhqQsHyWyaNJiHOULzYaMsIpqHupSTpp5qpI1fZ5LNJti/EibnE= =eOm8 -----END PGP SIGNATURE----- --MjMSuRCj7efoLfj47VhtArK6dpfuwEuTE--