From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87Br-0006wF-CF for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:23:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X87Bl-0007fo-E6 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:23:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87Bl-0007fV-6y for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:23:01 -0400 Message-ID: <53C911A2.60103@redhat.com> Date: Fri, 18 Jul 2014 06:22:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <1405596081-29701-6-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-6-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="orXIAALGrGotXOUAfa9IadAPW3Cfteqrn" Subject: Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --orXIAALGrGotXOUAfa9IadAPW3Cfteqrn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Signed-off-by: Sanidhya Kashyap > --- > hmp-commands.hx | 14 ++++++++++++++ > hmp.c | 5 +++++ > hmp.h | 1 + > qapi-schema.json | 8 ++++++++ > qmp-commands.hx | 21 +++++++++++++++++++++ > savevm.c | 19 +++++++++++++++++++ > 6 files changed, 68 insertions(+) So here you provide HMP and QMP in one patch (fine); but earlier you separated them between 3/8 and 4/8. Might be nice to be consistent in the series. >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 575df78..61eca66 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1804,6 +1804,20 @@ STEXI > dumps the writable working set of a VM's memory to a file > ETEXI > =20 > + { > + .name =3D "ldbc|log-dirty-bitmap-cancel", HMP commands still use _ in their names; it's only QMP where we prefer da= sh. > +++ b/qapi-schema.json > @@ -3503,3 +3503,11 @@ > 'data' : { 'filename' : 'str', > '*epochs' : 'int', > '*frequency' : 'int' } } > +## > +# @log-dirty-bitmap-cancel > +# > +# cancel the dirty bitmap logging process > +# > +# Since 2.2 > +## > +{ 'command': 'log-dirty-bitmap-cancel' } Correctly named with dash here... > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 200f57e..69d4a07 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3785,3 +3785,24 @@ Examples: > Note: The epochs, frequency and readable are optional. epochs default > value is 3 while that of frequency is 10. > EQMP > + > + { > + .name =3D "log-dirty-bitmap-cancel", > + .args_type =3D "", > + .mhandler.cmd_new =3D qmp_marshal_input_log_dirty_bitmap_cance= l, > + }, > + > +SQMP > +log_bitmap_cancel =2E..but completely wrong name here. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --orXIAALGrGotXOUAfa9IadAPW3Cfteqrn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyRGiAAoJEKeha0olJ0NqIZ8H/i2YOwg5CaeEVegqtP5IanJE WGV6wHIan3ba6ucmg4yghI4vT1osTuOs2aqHTENB/zEqoXSXqLsiOpmgCcNa+/Fn JCLDxCouhu3H1/KalmqFXIZYsGFp/ow2D4esTYBy48SjmZ7M/KxmpTbh9qa1PX5w k7rNab2oyQnLAjysxJIgtXiNC2+CZf6rLqWJ7nyQa4wHIcm+Q9cU3foFJ7G7t82Z 7EyGNQXKgEr2T7BCY6Sd3PXRXxrKIp28O8AvuJw3bxMXqFOjMFHmwx9MRpPi+vje f4g21050y7PXXJ9o2KDJcCGQfC+BfP88Re+9a5iPxTD/P4rq3/JRJEtzVV82KS4= =RKH4 -----END PGP SIGNATURE----- --orXIAALGrGotXOUAfa9IadAPW3Cfteqrn--