From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87Gs-0001vw-CM for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:28:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X87Gk-0000sk-Mc for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:28:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87Gk-0000sg-EP for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:28:10 -0400 Message-ID: <53C912D2.1050805@redhat.com> Date: Fri, 18 Jul 2014 06:28:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <1405596081-29701-7-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-7-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HLw3aVWA4sOMewWXiG2c80OmT7qFHQsjV" Subject: Re: [Qemu-devel] [PATCH v4 6/8] BitmapLog: set the frequency of the dump bitmap process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HLw3aVWA4sOMewWXiG2c80OmT7qFHQsjV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Rectified the example mistake in qmp-commands.hx. Is this comment about a mistake that existed prior to your series, or is it a changelog compared to v1-3 of your posts? If the former, it might be nice to say which existing commit was buggy (so we know how long the docs have been broken); if the latter, then please make it obvious that it is a patch revision changelog by moving the comment out of the commit message... >=20 > Signed-off-by: Sanidhya Kashyap > --- =2E..and sticking it here. Remember, this is the location for comments that aid review for someone that has looked at earlier revisions of your series, but which add no value to the qemu.git log a year from now when only the final version of your series is in place. > hmp-commands.hx | 15 +++++++++++++++ > hmp.c | 12 ++++++++++++ > hmp.h | 1 + > qapi-schema.json | 13 +++++++++++++ > qmp-commands.hx | 24 ++++++++++++++++++++++++ > savevm.c | 14 ++++++++++++++ > 6 files changed, 79 insertions(+) Given that your patch is purely additive, I conclude that your commit comment is in relation to your v1-3 postings of the series, and thus misplaced. > +++ b/qapi-schema.json > @@ -3511,3 +3511,16 @@ > # Since 2.2 > ## > { 'command': 'log-dirty-bitmap-cancel' } > + > +## > +# @log-dirty-bitmap-set-frequency > +# > +# sets the frequency of the dirty bitmap logging process > +# @frequency: the updated frequency value (in milliseconds). > +# The min and max values are 10 and 100000 respectively. > +# > +# Since 2.2 > +## > +{ 'command': 'log-dirty-bitmap-set-frequency', > + 'data': {'frequency': 'int' } } I hate write-only commands. Where is the counterpart query command that I can use to learn if I am currently logging, and what the current logging frequency is? > + > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 69d4a07..0a13b74 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3806,3 +3806,27 @@ Example: > <- { "return": {} } > =20 > EQMP > + > + { > + .name =3D "log-dirty-bitmap-set-frequency", > + .args_type =3D "frequency:i", > + .mhandler.cmd_new =3D qmp_marshal_input_log_dirty_bitmap_set_f= requency, > + }, > + > +SQMP > +log-dirty-bitmap-set-frequency > +-------------------- Nit - the separator line is typically the same length as the command name, for better visual appeal. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HLw3aVWA4sOMewWXiG2c80OmT7qFHQsjV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyRLSAAoJEKeha0olJ0NqYjQIAIWJBXhws43CJLMr0JLPjdzs biowaD3DH8HDSIz75vjLweSXxrPm2e+W5YzbKiuhlciakyIKSsw6gpp4TXk6V3p5 34xUTfK/A3kV96fQdge5IhZ/GXJGVBaTOnfA0KiQElIkdIElxbPKGwRJDpjgfXf+ ez247QJK3B0p8SQg3NT9HrTU1WPSzIEGLNg4+3pmMy6lQm8z467HbKQENKgkmS6a X0HV3LCnNmPK4HFqNudFgd9dTz3jGqukASsW5p6e4Wi7mycpUJpAFUKI9s4la1cg 11lbwVVlUmrUfDNGUIPhpL+iHm6fOuDdxEegm0kSqqHln/BfNtzNuQghUP3pKcc= =6VIH -----END PGP SIGNATURE----- --HLw3aVWA4sOMewWXiG2c80OmT7qFHQsjV--