From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87NZ-0005jA-Ko for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:35:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X87NT-0002mp-SQ for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:35:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87NT-0002mQ-KP for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:35:07 -0400 Message-ID: <53C91478.5020709@redhat.com> Date: Fri, 18 Jul 2014 06:35:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <1405596081-29701-8-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-8-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hsr6SQVW04UJjTNopccRmOIKSktGPphUh" Subject: Re: [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hsr6SQVW04UJjTNopccRmOIKSktGPphUh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Added the qmp interface to know about the information of the bitmap dum= p > process. When the command is executed, one can know about the current e= poch > value in which the process is in, the total iterations value and the cu= rrent > frequency value. >=20 > Currently, I do not think that that one needs to modify the other value= s > except frequency, so that is why I have not added the generic set-tunin= g > interface. If required, I will add it. >=20 > Signed-off-by: Sanidhya Kashyap > --- > qapi-schema.json | 31 +++++++++++++++++++++++++++++++ > qmp-commands.hx | 24 ++++++++++++++++++++++++ > savevm.c | 26 ++++++++++++++++++++++++++ > 3 files changed, 81 insertions(+) Ah, this answers one of my questions in 6/8. I would reorder the series and put this right after 3/8 (being able to query initial values is still useful, whether or not we also add on-the-fly tuning commands). >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 90977eb..1b09235d 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3487,6 +3487,24 @@ > { 'command': 'rtc-reset-reinjection' } > =20 > ## > +# @BitmapLogStateInfo > +# > +# Provides information for the bitmap logging process > +# > +# @currepoch: provides the value of the running epoch value No need to abbreviate. And given my naming question in 3/8, would this be better as: current-iteration > +# > +# @epochs: provides the information about the actual epoch and iterations Wait. Is this number a constant (the number requested when logging started, no matter what currepoch is)...[1] > +# > +# @frequency: the time difference in milliseconds between each epcoh s/epcoh/epoch/ (or iteration) > +# > +# Since 2.2 > +## > +{ 'type': 'BitmapLogStateInfo', > + 'data': { 'currepoch': 'int', > + 'epochs': 'int', > + 'frequency': 'int' } } > + > +## > # @log-dirty-bitmap > # > # dumps the dirty bitmap to a file by logging the > @@ -3524,3 +3542,16 @@ > { 'command': 'log-dirty-bitmap-set-frequency', > 'data': {'frequency': 'int' } } > =20 > +## > +# @log-dirty-bitmap-get-tuning Most query interfaces are in the query- namespace. Maybe this would be better as query-log-dirty-bitmap? > +# > +# Get the current values of the parameters involved in bitmap logging= process Accidental double space. > +# > +# This command returns the following elements in the form of BitmapLog= StateInfo: > +# - currepoch: current epoch value > +# - epochs: total epochs for which the bitmap dumping will continue =2E..[1]or is it the number of iterations remaining (that is, currepoch+epochs is the original value, and both numbers are changing as iterations progress)? Rather than duplicate the parameters in two places (and with different information, which led to my question about semantics), it might be nicer to just mention here that the information is returned as a BitmapLogStateInfo and be done with it (the user can go look up the documentation of that struct). > +# - frequently: the current sleep interval between each epoch s/frequently/frequency/ > +# > +# Since 2.2 > +## > +{ 'command': 'log-dirty-bitmap-get-tuning', 'returns': 'BitmapLogState= Info' } > +Get the parameters information > + > +- "currepoch": the current epoch going on > +- "epochs" the total number of assigned epochs > +- "frequency": the sleep interval between each epoch (in milliseconds)= > + > +Example: > + > +-> { "execute": "log-dirty-bitmap-get-tuning" } > +<- { "return": { > + "currepoch": 3 > + "epochs": 100 > + "frequency": 100 } } Invalid JSON. You are missing two commas. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hsr6SQVW04UJjTNopccRmOIKSktGPphUh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyRR4AAoJEKeha0olJ0NqkigH/1wTtZqEsBxA7m/ITGUg/8At 1GAHMS3JDaxjBALI7wtnp6v4GZ8cmK+VqjEfEfpC1mE1xna0Bs1wYpZnJnkmIxXl bKKExF+S27c8mR5wk65cuYSQfvzpOpiLMQfAoULxbY9mAwulAI+UkL12M2PFOTF5 ZGzYOAFATBtHqn3zPi0yYvyBOnDJyxYqcno5sdMu7jHU/iBgZz9ngcPektZxmHst NhBB2zMphvfxjOd5lSghnAbAg67wHqj6uvux/tu/65cPWxQSq6ZIGRfXfNxJ5zuo F2IavecTu/qqS0ttQTCT1VInhBWLLYo+Sfr5rCyi+jIgSaZ1CRore9k4dfTa12g= =A+aL -----END PGP SIGNATURE----- --hsr6SQVW04UJjTNopccRmOIKSktGPphUh--