From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87RU-0007lM-Pg for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:39:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X87RP-00042T-0V for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:39:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X87RO-00042O-MR for qemu-devel@nongnu.org; Fri, 18 Jul 2014 08:39:10 -0400 Message-ID: <53C91567.3010504@redhat.com> Date: Fri, 18 Jul 2014 06:39:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bW1xkhGNUFqjIsbuVEh4SDB5WFblwxSF6" Subject: Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bW1xkhGNUFqjIsbuVEh4SDB5WFblwxSF6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Hi, >=20 > The following patches introduce the support of the dirty bitmap logging= and > dumping to a specified file. This patch addresses the previous issues r= aised > by David and Juan. Since, I have not received any comments on the runst= ates, > I'll keep them in the patch series. I'm really not sure you need to be introducing a new runstate. I'm not an expert in runstates, but it feels fishy to me - adding a new state causes all sorts of complications (can I pause a domain that is logging a bitmap? If I resume a paused domain, does it resume back to normal running or back to logging?). We _don't_ have a new state for block jobs, and this feels similar to a block job. Remember, it is still possible to block migration for the duration of certain block jobs. If that was your goal (prevent migration and logging at the same time, because they stomp over each other's use of the dirty bitmap), then I think it would be sufficient to have this behave more like a block job that can inhibit migration, but not as an entirely new runstate. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bW1xkhGNUFqjIsbuVEh4SDB5WFblwxSF6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyRVnAAoJEKeha0olJ0Nq3rYH/0LJ4GmSng18MStUzKB0NJFX Kb5JMU8co0JDYxoGvbQ4ZBWIZTRk+rG+67Qa0iXoyftiHk8/Vztw3lsBheI/R9sV lGdZBuRwi/0Gq9Vj/n1drw//lJDhPXCZSn0myuU1snTtClDK9HdUylynRgQ9lvsf ntro+BQYLKkM3aVwbi10GzS5M6ORs9vDX1CiaSCbGETfwnTg3nBRqTu4fza23ubZ X60v405FuF2/cThtEKShG+VV1BrJwNYlBn5lzVvzqQkKdRwbdP07dVVrTcHf3JI1 rh5xpldFvjK6S5ElodAVQq3m6aPK3l3pUAmJoCvhUn1cv1tgwqAhaYkKsw+37+Q= =p8e+ -----END PGP SIGNATURE----- --bW1xkhGNUFqjIsbuVEh4SDB5WFblwxSF6--