From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X88Qv-0006QL-7M for qemu-devel@nongnu.org; Fri, 18 Jul 2014 09:42:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X88Qq-0005pc-9u for qemu-devel@nongnu.org; Fri, 18 Jul 2014 09:42:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X88Qp-0005pL-W3 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 09:42:40 -0400 Message-ID: <53C9244C.9000600@redhat.com> Date: Fri, 18 Jul 2014 07:42:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <20140718105655.GB2384@work-vm> In-Reply-To: <20140718105655.GB2384@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="opDC4huiiQDqBf2U09A3L9NMoC8oh5HFR" Subject: Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Sanidhya Kashyap Cc: Amit Shah , qemu list , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --opDC4huiiQDqBf2U09A3L9NMoC8oh5HFR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2014 04:56 AM, Dr. David Alan Gilbert wrote: > * Sanidhya Kashyap (sanidhya.iiith@gmail.com) wrote: >> Hi, >> >> The following patches introduce the support of the dirty bitmap loggin= g and >> dumping to a specified file. This patch addresses the previous issues = raised >> by David and Juan. Since, I have not received any comments on the runs= tates, >> I'll keep them in the patch series. >=20 > Hi Sanidhya, > I've finally got around to reading through your patches. Some genera= l > thoughts first, and I'll put some more detail on the patches themselves= : >=20 > 1) Do you have some examples of output? > Can you see hot areas in the kernel or something else? >=20 > 2) 'frequency' is probably the wrong name for the parameter you have; s= ince > the parameter is actually the delay between epochs, where as frequency > would imply the number of epochs/second. Agreed, please s/frequency/period/ throughout. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --opDC4huiiQDqBf2U09A3L9NMoC8oh5HFR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTySRNAAoJEKeha0olJ0NqtacH/0G6mUg2y2gqIT4Y4EBen0bu 77c2/jw9aksNWuGDbIM0m6HtfHIG6cd9f5uA9Mm5IiIU+YDCHbN6+M1ayE7eAs0A T0yRaYsis0msTimVkIJ4K8zzleluv1yfK5o5hHvIp7/MN3WnloU02TGHF58NjYsh EQ0zwz/Fh/Mviu9CVmKsKckToW76+Oso0zYkzQzUSGnzHMQO96YQM2QOJY+I1FE7 DfSC+Ildr1U1yKo96no6Vcz8eycBpPTrlqhtrZ6u8Yixbv4j1ZV4CS3qO2qXP/b7 oYiHW+sY0Uk1D1Q0bskKaA3ysH5WNrLOCJtUNDqPISNZEJvOpM5uT2ePhyzd5g0= =466r -----END PGP SIGNATURE----- --opDC4huiiQDqBf2U09A3L9NMoC8oh5HFR--