From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X88wk-0002ez-Vf for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X88wd-0005P8-Dj for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:15:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58607 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X88wd-0005Om-4w for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:15:31 -0400 Message-ID: <53C92C02.5020608@suse.de> Date: Fri, 18 Jul 2014 16:15:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <20140629113701.GA26161@redhat.com> <1405606506.2696.60.camel@localhost.localdomain> <53C7DB9F.1060305@redhat.com> <53C7F06B.4080103@suse.de> <20140717164731.23073.74542@loki> <53C80114.7080302@redhat.com> In-Reply-To: <53C80114.7080302@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Michael Roth , Marcel Apfelbaum , Peter Maydell Cc: qemu-devel@nongnu.org, aliguori@amazon.com, "Michael S. Tsirkin" Am 17.07.2014 19:00, schrieb Paolo Bonzini: > Il 17/07/2014 18:47, Michael Roth ha scritto: >>> > My argument for getting this into 2.1 had been to avoid tools >>> picking up >>> > these to-be-renamed property names from the start. At this point, I= 'm >>> > not so sure whether it's worse to break management tools or >>> potentially >>> > some rarely used/tested option - if we decide for 2.2, is >>> backporting to >>> > 2.1.1 an option if we document it in the release notes? >> IMO, if there's some risk to breaking management or other tools, I'd >> rather it be left to major releases. And if these values are already >> misnamed >> for 2.1.0 and prior, I don't think we stop it from poliferating much >> more by >> pushing the fix up by a few months. >=20 > I'm not sure in which case management could break (except for qom-get). > Andreas, can you explain? I was mainly concerned about qom-set, but same goes for qom-get. The breakage would be in 2.2, if in 2.1 we introduce properties with foo_bar and rename them to foo-bar in 2.2. Since they're not in 2.0, I had asked Marcel to rename them for 2.1 on a KVM call. I checked that sPAPR is not affected, so the only issue is the trivial g_free(). Since apart from sPAPR we have a compact snippet of properties being added, grep'ing for occurrences of the old strings and verifying that the patch changes all properties should be safe for -rc3 if Peter would be willing to take a pull. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg