From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X890Z-0005ug-G6
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:19:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X890T-0007yK-Am
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:19:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22887)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X890T-0007xo-2g
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:19:29 -0400
Message-ID: <53C92CE5.8020806@redhat.com>
Date: Fri, 18 Jul 2014 16:19:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com>
	<20140629113701.GA26161@redhat.com>
	<1405606506.2696.60.camel@localhost.localdomain>
	<53C7DB9F.1060305@redhat.com> <53C7F06B.4080103@suse.de>
	<20140717164731.23073.74542@loki> <53C80114.7080302@redhat.com>
	<53C92C02.5020608@suse.de>
In-Reply-To: <53C92C02.5020608@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's
 property names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Michael Roth <mdroth@linux.vnet.ibm.com>, Marcel Apfelbaum <marcel.a@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com, "Michael S. Tsirkin" <mst@redhat.com>

Il 18/07/2014 16:15, Andreas F=C3=A4rber ha scritto:
> I was mainly concerned about qom-set, but same goes for qom-get. The
> breakage would be in 2.2, if in 2.1 we introduce properties with foo_ba=
r
> and rename them to foo-bar in 2.2. Since they're not in 2.0, I had aske=
d
> Marcel to rename them for 2.1 on a KVM call.
>=20
> I checked that sPAPR is not affected, so the only issue is the trivial
> g_free(). Since apart from sPAPR we have a compact snippet of propertie=
s
> being added, grep'ing for occurrences of the old strings and verifying
> that the patch changes all properties should be safe for -rc3 if Peter
> would be willing to take a pull.

Okay, I agree.

Paolo