From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Cc: mdroth@linux.vnet.ibm.com, aliguori@amazon.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names
Date: Fri, 18 Jul 2014 16:38:18 +0200 [thread overview]
Message-ID: <53C9315A.3010108@redhat.com> (raw)
In-Reply-To: <53C92E49.7090001@suse.de>
Il 18/07/2014 16:25, Andreas Färber ha scritto:
> Actually, is this really safe? By my reading, this function handles
> -object as well, which in turn allows - in theory - to instantiate any
> device, where some will still have underscores in their property names.
> Not sure if all non-device objects such as virtio-rng backends have been
> checked?
I guess you would have to change devices from _ to - before adding
UserCreatable to devices.
-object backends are safe, they only use - (virtio-rng doesn't even have
dashes).
Paolo
next prev parent reply other threads:[~2014-07-18 14:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 9:09 [Qemu-devel] [PATCH] machine: replace underscores in machine's property names Marcel Apfelbaum
2014-06-29 11:37 ` Michael S. Tsirkin
2014-07-17 14:15 ` Marcel Apfelbaum
2014-07-17 14:20 ` Paolo Bonzini
2014-07-17 15:48 ` Andreas Färber
2014-07-17 16:47 ` Michael Roth
2014-07-17 17:00 ` Paolo Bonzini
2014-07-18 14:15 ` Andreas Färber
2014-07-18 14:19 ` Paolo Bonzini
2014-07-18 16:06 ` Marcel Apfelbaum
2014-07-17 16:55 ` Peter Maydell
2014-07-17 16:59 ` Marcel Apfelbaum
2014-07-18 14:25 ` Andreas Färber
2014-07-18 14:38 ` Paolo Bonzini [this message]
2014-07-18 15:59 ` Marcel Apfelbaum
2014-07-18 16:10 ` Andreas Färber
2014-07-18 16:23 ` Marcel Apfelbaum
2014-07-18 16:32 ` Andreas Färber
2014-07-18 16:35 ` Marcel Apfelbaum
2014-07-18 20:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C9315A.3010108@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=marcel.a@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).