From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X89J0-0004X8-1P for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:38:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X89Is-0007zo-Jh for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:38:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X89Is-0007zX-Bg for qemu-devel@nongnu.org; Fri, 18 Jul 2014 10:38:30 -0400 Message-ID: <53C9315A.3010108@redhat.com> Date: Fri, 18 Jul 2014 16:38:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <53C92E49.7090001@suse.de> In-Reply-To: <53C92E49.7090001@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Marcel Apfelbaum , qemu-devel@nongnu.org, Peter Maydell Cc: mdroth@linux.vnet.ibm.com, aliguori@amazon.com, mst@redhat.com Il 18/07/2014 16:25, Andreas F=E4rber ha scritto: > Actually, is this really safe? By my reading, this function handles > -object as well, which in turn allows - in theory - to instantiate any > device, where some will still have underscores in their property names. > Not sure if all non-device objects such as virtio-rng backends have bee= n > checked? I guess you would have to change devices from _ to - before adding UserCreatable to devices. -object backends are safe, they only use - (virtio-rng doesn't even have dashes). Paolo