From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8AbD-0005jA-8k for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:01:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8Ab8-0002so-7V for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:01:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Ab7-0002sj-VU for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:01:26 -0400 Message-ID: <53C94417.9070603@redhat.com> Date: Fri, 18 Jul 2014 09:58:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140717110153.8352.80175.stgit@PASHA-ISP> <20140717110622.8352.9431.stgit@PASHA-ISP> In-Reply-To: <20140717110622.8352.9431.stgit@PASHA-ISP> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AI9Nk2mbWpFA9O47QmQSXU033kOvDVvWq" Subject: Re: [Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, pbonzini@redhat.com, fred.konrad@greensocs.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AI9Nk2mbWpFA9O47QmQSXU033kOvDVvWq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote: > This patch adds support for replay_break monitor command. This command > sets the step (measured in executed instructions) where replay should b= e > stopped. >=20 > Signed-off-by: Pavel Dovgalyuk > --- > hmp-commands.hx | 14 ++++++++++++++ > monitor.c | 15 +++++++++++++++ > qapi-schema.json | 11 +++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > replay/replay-qmp.c | 13 +++++++++++++ > replay/replay.c | 24 +++++++++++++++++++++++- > replay/replay.h | 2 ++ > 7 files changed, 101 insertions(+), 1 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -3518,3 +3518,14 @@ > # Since: 2.2 > ## > { 'command': 'replay_info', 'returns': 'ReplayInfo' } > + > +## > +# @replay_break replay-break in QMP > +# > +# Sets breakpoint at the specified step of replaying > +# > +# @step: step where breakpoint should be set > +# > +# Since: 2.2 Is the double space intentional? This is a very high-level description - reading just this definition, I don't know what typical settings are, and whether changing the number to be larger or smaller makes a difference. Might be worth a bit more docs.= I hate write-only interfaces - how do I query what the current breakpoint step is? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AI9Nk2mbWpFA9O47QmQSXU033kOvDVvWq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTyUQXAAoJEKeha0olJ0NqltcH/A1TS+1quIcfmr4dwfAJ2OQt TAZwnOHWbUagZ33SrQENeqg0SaZG15gIMM4/64j1FXJrJDUDp3Ujyd8stecxy3it S9Q0BzqWULe+dl6hA3eS1UccK5SYjexdRe0f2lBm0sb1/qIZxhy099ar50Duw9SS C3RqF6bdR6sx+FUre+uDnZPFE7HRQqKFMITmZEIJ8g0e3/cgRMbFUZ3CVGy6osnR O4KXIjqSoslKuqSGU8UEiEq4Csg/yLoD20BExZ0n+jT2bq9/ADdlMcK0Csj7bS4C cULwHK/6P9fYKleBijxuKHJL5Xusx9ocMps9Oe9Xv813DPwStmgBXNvEfhflQy4= =Fkac -----END PGP SIGNATURE----- --AI9Nk2mbWpFA9O47QmQSXU033kOvDVvWq--