From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Ak4-0003pL-Ja for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:10:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8Ajw-00068V-QU for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:10:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:32829 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Ajw-00068P-JW for qemu-devel@nongnu.org; Fri, 18 Jul 2014 12:10:32 -0400 Message-ID: <53C946F6.4040908@suse.de> Date: Fri, 18 Jul 2014 18:10:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <53C92E49.7090001@suse.de> <1405699194.2696.84.camel@localhost.localdomain> In-Reply-To: <1405699194.2696.84.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , Paolo Bonzini Cc: Peter Maydell , mst@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, mdroth@linux.vnet.ibm.com Hi, Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > On Fri, 2014-07-18 at 16:25 +0200, Andreas F=C3=A4rber wrote: >> Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: >>> Replaced '_' with '-' to comply with QOM guidelines. >>> Made the conversion from HMP to QMP in vl.c >>> >>> Signed-off-by: Marcel Apfelbaum >>> --- >>> hw/core/machine.c | 8 ++++---- >>> vl.c | 12 +++++++++++- >>> 2 files changed, 15 insertions(+), 5 deletions(-) >> [snip] >>> diff --git a/vl.c b/vl.c >>> index a1686ef..7587c97 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -2820,15 +2820,25 @@ static int object_set_property(const char *na= me, const char *value, void *opaque >>> Object *obj =3D OBJECT(opaque); >>> StringInputVisitor *siv; >>> Error *local_err =3D NULL; >>> + char *c, *qom_name; >>> =20 >>> if (strcmp(name, "qom-type") =3D=3D 0 || strcmp(name, "id") =3D=3D= 0 || >>> strcmp(name, "type") =3D=3D 0) { >>> return 0; >>> } >>> =20 >>> + qom_name =3D g_strdup(name); >>> + c =3D qom_name; >>> + while (*c++) { >>> + if (*c =3D=3D '_') { >>> + *c =3D '-'; >>> + } >>> + } >> >> Actually, is this really safe? By my reading, this function handles >> -object as well, which in turn allows - in theory - to instantiate any >> device, where some will still have underscores in their property names= . >> Not sure if all non-device objects such as virtio-rng backends have be= en >> checked? > Hi Andreas, >=20 > I checked and object_set_property is used only be machine right now, so > no problem here. Indeed you are right. If -object is no longer using it, can we drop qom-type handling? What changed there? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg