From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8CA9-0006e2-88 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 13:41:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8C9w-00017p-24 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 13:41:41 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:41933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8C9v-00017Z-R3 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 13:41:27 -0400 Received: by mail-pa0-f50.google.com with SMTP id et14so5787840pad.23 for ; Fri, 18 Jul 2014 10:41:26 -0700 (PDT) Message-ID: <53C95C32.70307@gmail.com> Date: Fri, 18 Jul 2014 23:11:06 +0530 From: Sanidhya Kashyap MIME-Version: 1.0 References: <1405596081-29701-1-git-send-email-sanidhya.iiith@gmail.com> <1405596081-29701-8-git-send-email-sanidhya.iiith@gmail.com> <53C91478.5020709@redhat.com> In-Reply-To: <53C91478.5020709@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu list Cc: Amit Shah , "Dr. David Alan Gilbert" , Juan Quintela -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > > No need to abbreviate. And given my naming question in 3/8, would > this be better as: current-iteration > Okay, I will surely modify it. >> +# +# @epochs: provides the information about the actual epoch > > and iterations > > Wait. Is this number a constant (the number requested when > logging started, no matter what currepoch is)...[1] > yup. > Most query interfaces are in the query- namespace. Maybe this > would be better as query-log-dirty-bitmap? > My bad, I didn't look others clearly. Since, you pointed out to use get-tuning and set-tuning in one of my other patches; so, I used get-tuning. Will make the relevant changes. >> +# +# Get the current values of the parameters involved in >> bitmap logging process > > Accidental double space. > >> +# +# This command returns the following elements in the form of >> BitmapLogStateInfo: +# - currepoch: current epoch value +# - >> epochs: total epochs for which the bitmap dumping will continue > > ...[1]or is it the number of iterations remaining (that is, > currepoch+epochs is the original value, and both numbers are > changing as iterations progress)? Rather than duplicate the > parameters in two No, currepoch changes while the epoch is a fix value. Need to change the names :-/. They are confusing. > places (and with different information, which led to my question > about semantics), it might be nicer to just mention here that the > information is returned as a BitmapLogStateInfo and be done with it > (the user can go look up the documentation of that struct). > Will do that. - -- - ----- Sanidhya Kashyap -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTyVwyAAoJEFt9RLmoahlnS1QH/36mLxnS3sblvYI6v7fJxAF0 bklZpcUKVmanLaOTY498FD8kZN2//Q5rPlJis2AiMAyZ7I1zz4JdPjW+hfjRI+Lb KgewG4T6tP3zPzponD4EUcIrBOLlgTIuNwP7Rd+8Cpy37MkFm3MyUqU4kVwS98wS MY99/UBEMkX/+IXLANAOjOmTIjwgg/HU2NyhMUFbR4tiYWdQCtozfr+/uBfz2tBg AMTy3gkPTMvB/frXovBN+V2KfdJPn14oaBxdfms94SSwmsfOz1ot4j0nx1MuwoPW XOL6t/P9W1w3V43av/NG+U2CUPo8NCb5S1MmZse5oqx1CPvbhoDIlYOySmp//Pg= =IyAr -----END PGP SIGNATURE-----