From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8DNa-0004j9-KC for qemu-devel@nongnu.org; Fri, 18 Jul 2014 14:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8DNU-00089c-Tk for qemu-devel@nongnu.org; Fri, 18 Jul 2014 14:59:38 -0400 Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]:58210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8DNU-00089X-M4 for qemu-devel@nongnu.org; Fri, 18 Jul 2014 14:59:32 -0400 Received: by mail-pd0-f178.google.com with SMTP id w10so5459316pde.23 for ; Fri, 18 Jul 2014 11:59:31 -0700 (PDT) Message-ID: <53C96E8A.1090203@gmail.com> Date: Sat, 19 Jul 2014 00:29:22 +0530 From: Sanidhya Kashyap MIME-Version: 1.0 References: <1404753484-26693-1-git-send-email-sanidhya.iiith@gmail.com> <1404753484-26693-5-git-send-email-sanidhya.iiith@gmail.com> <53BAE622.8070706@redhat.com> In-Reply-To: <53BAE622.8070706@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of the vmstate testing process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu list Cc: "Dr. David Alan Gilbert" , Juan Quintela -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > This feels like a write-only command. How do I query what it is > currently set to? > > I'm also afraid that we aren't learning our lessons from migrate. > Adding one new command per new tunable does not scale very well in > the number of commands that need to be maintained or that have to > be wired up in management software; better is adding a single > command pair for set/get that can be easily introspected (to see > when new tunables are added), by taking an array of tunables where > each tunable is a struct containing name, type, and value > information. Something like: > > {"execute":"test-vmstates-set-tuning", "arguments":{ "list":[ { > "name":"sinterval", "type":"int", "value":100 }, { "name":"other", > "type":"...", "value":... } ]}} {"return": {}} > > and a counterpart: > > {"execute":"test-vmstates-get-tuning" } {"return": [ { > "name":"sinterval", "type":"int", "value":100 }, { "name":"other", > "type":"...", "value":... } ]} > > Well, I have some issues about the implementation of the list which is associated with the set-tuning one. Any patch illustrating the above example which includes list will help me a lot. Thanks. - -- - ----- Sanidhya Kashyap -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTyW6KAAoJEFt9RLmoahlnFQkIAJL6z0jo72gEc67ISr6pNxyH sxFbT67LNHhliWlVvohOPqC4e8hGOfXJb5gmPr2UFZUbVNKLrGc1Mh8t5OeRPR2y 3twA+3uUvpuJhc6F+KH4Z125Qirj7Uom9/PCtOYD9QMIAOEkD9SzD1S3ZpWL6I2r +l0s2xkFScG9eHyqe6pJlKRIORm9FnKVhYS18bzXz1WWh1mJTjF6qXNfbCS3OyqT 9rk1ZcYyYei/JNoclgC7Mvxy5QpQxrhhjwDFK0G3vFaPte+K+CYpGHL8a5s0sPFb OOZ29X+5Zz4wOx9btf0+LovqSwrLueHCdF/l65+jSNPRRsvB4MslQva/Rybs4Kg= =DpKh -----END PGP SIGNATURE-----