From: Max Reitz <mreitz@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, sw@weilnetz.de, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] block: use the standard 'ret' instead of 'result'
Date: Sat, 19 Jul 2014 15:23:31 +0200 [thread overview]
Message-ID: <53CA7153.8040109@redhat.com> (raw)
In-Reply-To: <3ed71014d6c4ea5e11ee62c0f205dd996c3ad8d5.1405715876.git.jcody@redhat.com>
On 18.07.2014 22:54, Jeff Cody wrote:
> Most QEMU code uses 'ret' for function return values. The VDI driver
> uses a mix of 'result' and 'ret'. This cleans that up, switching over
> to the standard 'ret' usage.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> block/vdi.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
(still applies if you have to change the penultimate hunk due to
s/bs->file/bs/ in patch 2)
next prev parent reply other threads:[~2014-07-19 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 20:53 [Qemu-devel] [PATCH 0/4] Allow VPC and VDI to be created over protocols Jeff Cody
2014-07-18 20:53 ` [Qemu-devel] [PATCH 1/4] block: allow bdrv_unref() to be passed NULL pointers Jeff Cody
2014-07-19 12:59 ` Max Reitz
2014-07-18 20:53 ` [Qemu-devel] [PATCH 2/4] block: vdi - use block layer ops in vdi_create, instead of posix calls Jeff Cody
2014-07-19 13:13 ` Max Reitz
2014-07-21 12:58 ` Jeff Cody
2014-07-21 13:02 ` Kevin Wolf
2014-07-18 20:54 ` [Qemu-devel] [PATCH 3/4] block: use the standard 'ret' instead of 'result' Jeff Cody
2014-07-19 13:23 ` Max Reitz [this message]
2014-07-18 20:54 ` [Qemu-devel] [PATCH 4/4] block: vpc - use block layer ops in vpc_create, instead of posix calls Jeff Cody
2014-07-19 13:33 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CA7153.8040109@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).