From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Uba-0007do-Iv for qemu-devel@nongnu.org; Sat, 19 Jul 2014 09:23:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8UbU-0002m4-Dn for qemu-devel@nongnu.org; Sat, 19 Jul 2014 09:23:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8UbU-0002lx-65 for qemu-devel@nongnu.org; Sat, 19 Jul 2014 09:23:08 -0400 Message-ID: <53CA7153.8040109@redhat.com> Date: Sat, 19 Jul 2014 15:23:31 +0200 From: Max Reitz MIME-Version: 1.0 References: <3ed71014d6c4ea5e11ee62c0f205dd996c3ad8d5.1405715876.git.jcody@redhat.com> In-Reply-To: <3ed71014d6c4ea5e11ee62c0f205dd996c3ad8d5.1405715876.git.jcody@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] block: use the standard 'ret' instead of 'result' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, sw@weilnetz.de, stefanha@redhat.com On 18.07.2014 22:54, Jeff Cody wrote: > Most QEMU code uses 'ret' for function return values. The VDI driver > uses a mix of 'result' and 'ret'. This cleans that up, switching over > to the standard 'ret' usage. > > Signed-off-by: Jeff Cody > --- > block/vdi.c | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) Reviewed-by: Max Reitz (still applies if you have to change the penultimate hunk due to s/bs->file/bs/ in patch 2)