From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Ulb-0002MO-CZ for qemu-devel@nongnu.org; Sat, 19 Jul 2014 09:33:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8UlU-0005qi-Oc for qemu-devel@nongnu.org; Sat, 19 Jul 2014 09:33:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8UlU-0005qU-Gh for qemu-devel@nongnu.org; Sat, 19 Jul 2014 09:33:28 -0400 Message-ID: <53CA73BF.7050404@redhat.com> Date: Sat, 19 Jul 2014 15:33:51 +0200 From: Max Reitz MIME-Version: 1.0 References: <0e40b71fd4a7f38ca31b9aa95ce9ad3305fbae00.1405715876.git.jcody@redhat.com> In-Reply-To: <0e40b71fd4a7f38ca31b9aa95ce9ad3305fbae00.1405715876.git.jcody@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] block: vpc - use block layer ops in vpc_create, instead of posix calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, sw@weilnetz.de, stefanha@redhat.com On 18.07.2014 22:54, Jeff Cody wrote: > Use the block layer to create, and write to, the image file in the VPC > .bdrv_create() operation. > > This has a couple of benefits: Images can now be created over protocols, > and host raw file optimizations (such as nocow) do not need to be > handled in the image format driver. > > Signed-off-by: Jeff Cody > --- > block/vpc.c | 99 +++++++++++++++++++++++++++---------------------------------- > 1 file changed, 43 insertions(+), 56 deletions(-) Reviewed-by: Max Reitz