qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: David Marchand <david.marchand@6wind.com>, qemu-devel@nongnu.org
Cc: Olivier Matz <olivier.matz@6wind.com>,
	kvm@vger.kernel.org, claudio.fontana@huawei.com,
	pbonzini@redhat.com, jani.kokkonen@huawei.com,
	cam@cs.ualberta.ca
Subject: Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server
Date: Mon, 21 Jul 2014 08:21:21 -0600	[thread overview]
Message-ID: <53CD21E1.1010908@redhat.com> (raw)
In-Reply-To: <1405849119-13569-2-git-send-email-david.marchand@6wind.com>

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On 07/20/2014 03:38 AM, David Marchand wrote:
> When using ivshmem devices, notifications between guests can be sent as
> interrupts using a ivshmem-server (typical use described in documentation).
> The client is provided as a debug tool.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  contrib/ivshmem-client/Makefile         |   26 ++

> +++ b/contrib/ivshmem-client/Makefile
> @@ -0,0 +1,26 @@
> +# Copyright 2014 6WIND S.A.
> +# All rights reserved

This file has no other license, and is therefore incompatible with
GPLv2.  You'll need to resubmit under an appropriately open license.

> +++ b/contrib/ivshmem-client/ivshmem-client.h
> @@ -0,0 +1,238 @@
> +/*
> + * Copyright(c) 2014 6WIND S.A.
> + * All rights reserved.
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.

I'm not a lawyer, but to me, this license is self-contradictory.  You
can't have "All rights reserved" and still be GPL, because the point of
the GPL is that you are NOT reserving all rights, but explicitly
granting your user various rights (on condition that they likewise grant
those rights to others).  But you're not the only file in the qemu code
base with this questionable mix.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-07-21 14:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20  9:38 [Qemu-devel] [PATCH v2 0/2] ivshmem: update documentation, add client/server tools David Marchand
2014-07-20  9:38 ` [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server David Marchand
2014-07-21 14:21   ` Eric Blake [this message]
2014-07-21 14:30     ` Daniel P. Berrange
2014-07-21 15:26     ` David Marchand
2014-07-21 17:35   ` Markus Armbruster
2014-08-08  8:49     ` David Marchand
2014-07-20  9:38 ` [Qemu-devel] [PATCH v2 2/2] docs: update ivshmem device spec David Marchand
2014-07-21  8:19   ` Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CD21E1.1010908@redhat.com \
    --to=eblake@redhat.com \
    --cc=cam@cs.ualberta.ca \
    --cc=claudio.fontana@huawei.com \
    --cc=david.marchand@6wind.com \
    --cc=jani.kokkonen@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=olivier.matz@6wind.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).