From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9FTz-000298-KS for qemu-devel@nongnu.org; Mon, 21 Jul 2014 11:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9FTs-00071c-50 for qemu-devel@nongnu.org; Mon, 21 Jul 2014 11:26:31 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:51973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9FTr-00071X-VA for qemu-devel@nongnu.org; Mon, 21 Jul 2014 11:26:24 -0400 Received: by mail-we0-f175.google.com with SMTP id t60so7713909wes.20 for ; Mon, 21 Jul 2014 08:26:19 -0700 (PDT) Message-ID: <53CD3118.7060403@6wind.com> Date: Mon, 21 Jul 2014 17:26:16 +0200 From: David Marchand MIME-Version: 1.0 References: <1405849119-13569-1-git-send-email-david.marchand@6wind.com> <1405849119-13569-2-git-send-email-david.marchand@6wind.com> <53CD21E1.1010908@redhat.com> In-Reply-To: <53CD21E1.1010908@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Olivier Matz , kvm@vger.kernel.org, claudio.fontana@huawei.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca Hello Eric, On 07/21/2014 04:21 PM, Eric Blake wrote: > On 07/20/2014 03:38 AM, David Marchand wrote: >> +# Copyright 2014 6WIND S.A. >> +# All rights reserved > > This file has no other license, and is therefore incompatible with > GPLv2. You'll need to resubmit under an appropriately open license. missed the makefiles ... > >> +++ b/contrib/ivshmem-client/ivshmem-client.h >> @@ -0,0 +1,238 @@ >> +/* >> + * Copyright(c) 2014 6WIND S.A. >> + * All rights reserved. >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2. See >> + * the COPYING file in the top-level directory. > > I'm not a lawyer, but to me, this license is self-contradictory. You > can't have "All rights reserved" and still be GPL, because the point of > the GPL is that you are NOT reserving all rights, but explicitly > granting your user various rights (on condition that they likewise grant > those rights to others). But you're not the only file in the qemu code > base with this questionable mix. > Hum, ok, will update. -- David Marchand