From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33350)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roger.pau@citrix.com>) id 1X9YWY-0006Ay-EC
	for qemu-devel@nongnu.org; Tue, 22 Jul 2014 07:46:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roger.pau@citrix.com>) id 1X9YWT-0007YS-Ay
	for qemu-devel@nongnu.org; Tue, 22 Jul 2014 07:46:26 -0400
Received: from smtp.citrix.com ([66.165.176.89]:58116)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roger.pau@citrix.com>) id 1X9YWS-0007Y4-V2
	for qemu-devel@nongnu.org; Tue, 22 Jul 2014 07:46:21 -0400
Message-ID: <53CE4F07.40804@citrix.com>
Date: Tue, 22 Jul 2014 13:46:15 +0200
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
MIME-Version: 1.0
References: <1400860669-21593-1-git-send-email-roger.pau@citrix.com>
	<1400860669-21593-3-git-send-email-roger.pau@citrix.com>
	<20140527132943.GD31463@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140527132943.GD31463@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only
	version of tap_open
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: xen-devel@lists.xenproject.org, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On 27/05/14 15:29, Stefan Hajnoczi wrote:
> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
>> The current behaviour of tap_open for BSD systems differ greatly from
>> it's Linux counterpart. Since FreeBSD supports interface renaming and
>> tap device cloning by opening /dev/tap, implement a FreeBSD specific
>> version of tap_open that behaves like it's Linux counterpart.
>>
>> This is specially important for toolstacks that use Qemu (like Xen
>> libxl), in order to have a unified behaviour across suported
>> platforms.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: xen-devel@lists.xenproject.org
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Cc: Anthony Liguori <aliguori@us.ibm.com>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>  net/tap-bsd.c |   70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>  1 files changed, 69 insertions(+), 1 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

I still don't see this committed to the repository, should I ping someone?

Thanks, Roger.