From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9gXj-000444-Kc for qemu-devel@nongnu.org; Tue, 22 Jul 2014 16:20:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9gXc-0002lY-2C for qemu-devel@nongnu.org; Tue, 22 Jul 2014 16:20:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9gXb-0002l8-Ps for qemu-devel@nongnu.org; Tue, 22 Jul 2014 16:20:04 -0400 Message-ID: <53CEC788.1000508@redhat.com> Date: Tue, 22 Jul 2014 22:20:24 +0200 From: Max Reitz MIME-Version: 1.0 References: <53CEC642.6020804@redhat.com> <20140722201924.GA31882@localhost.localdomain> In-Reply-To: <20140722201924.GA31882@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/5] block: vdi - use block layer ops in vdi_create, instead of posix calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com On 22.07.2014 22:19, Jeff Cody wrote: > On Tue, Jul 22, 2014 at 10:14:58PM +0200, Max Reitz wrote: >> On 21.07.2014 21:52, Jeff Cody wrote: >>> Use the block layer to create, and write to, the image file in the >>> VDI .bdrv_create() operation. >>> >>> This has a couple of benefits: Images can now be created over protocols, >>> and hacks such as NOCOW are not needed in the image format driver, and >>> the underlying file protocol appropriate for the host OS can be relied >> This sounds a bit strange to me, but I don't know if it's wrong. >> > You find the wording strange, or the logic itself? If the latter, the Just the wording. :-) > use of the posix calls (open(), write()) means that we cannot create > images over protocols such as gluster - so using the qemu block layer > operations instead means protocols are now supported. And NOCOW is > not needed in the image format driver now, since raw-posix does the > same thing (if the bs->file protocol driver is a host file on a posix > system). > >>> upon. >>> >>> Also some minor cleanup for error handling. >>> >>> Signed-off-by: Jeff Cody >>> --- >>> block/vdi.c | 68 ++++++++++++++++++++++++++----------------------------------- >>> 1 file changed, 29 insertions(+), 39 deletions(-) >>> >>> diff --git a/block/vdi.c b/block/vdi.c >>> index 197bd77..5fd9d5f 100644 >>> --- a/block/vdi.c >>> +++ b/block/vdi.c >>> @@ -681,7 +681,6 @@ static int vdi_co_write(BlockDriverState *bs, >> Anyway: >> >> Reviewed-by: Max Reitz