From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9hHh-00058D-Cc for qemu-devel@nongnu.org; Tue, 22 Jul 2014 17:07:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9hHc-0004QM-FU for qemu-devel@nongnu.org; Tue, 22 Jul 2014 17:07:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9hHc-0004QI-6w for qemu-devel@nongnu.org; Tue, 22 Jul 2014 17:07:36 -0400 Message-ID: <53CED292.9080703@redhat.com> Date: Tue, 22 Jul 2014 15:07:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406062723-28692-1-git-send-email-mreitz@redhat.com> <1406062723-28692-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1406062723-28692-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nBTSshiRtAlVtpdVTGVxs7M5ME1BHOP6T" Subject: Re: [Qemu-devel] [PATCH v2 1/2] qemu-img: Allow source cache mode specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nBTSshiRtAlVtpdVTGVxs7M5ME1BHOP6T Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/22/2014 02:58 PM, Max Reitz wrote: > Many qemu-img subcommands only read the source file(s) once. For these > use cases, a full write-back cache is unnecessary and mainly clutters > host cache memory. Though this is generally no concern as cache memory > is freely available and can be scaled by the host OS, it may become a > concern with thin provisioning. >=20 > For these cases, it makes sense to allow users to freely specify the > source cache mode (e.g. use no cache at all). >=20 > This commit adds a new switch (-T) for the qemu-img subcommands check, > compare, convert and rebase to specify the cache to be used for source > images (the backing file in case of rebase). >=20 > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 16 ++++++------ > qemu-img.c | 78 ++++++++++++++++++++++++++++++++++++++++++++----= -------- > qemu-img.texi | 14 +++++++--- > 3 files changed, 80 insertions(+), 28 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nBTSshiRtAlVtpdVTGVxs7M5ME1BHOP6T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTztKSAAoJEKeha0olJ0NqMTEH/13tr/z02E/hySstOrm4A9Xi KeP3pnRRMT2Kz/AAyYjxKd56wu/3O5dl1nC1fAyzxb4LONzQ0LM4hEPfBR24muis kqLjKdqq0IX4bZ08IvJXeYHKaSj8euh19pFWFFnEqPxpZk6yZ3Dbjt5JVA6KrMHI e9IAnlHtreY7TbfEOvpwe9daoo00Y+4ktbj8UWcCz6O/1JTs581IzlcIFrj+g649 P5KXoO+1yjhJv/8dA7+S0XTmLOHcFHiCC/PkLVbfC+LQkeqmWhNK0JV5bEDsxNXY cwCXk8wsptv8ze3lQ7ZYkGY9BD1F7rcIo8KERsVIvK5YnwE7tPIJdFbE24AZCHY= =G0m9 -----END PGP SIGNATURE----- --nBTSshiRtAlVtpdVTGVxs7M5ME1BHOP6T--